[OpenNMS/opennms] 90bf45: NMS-20125: validate node search input and correct ...

Scott Theleman via opennms-cvs <[email protected]> Mon, 03 Aug 2026 19:09:26 -0700
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20125-node-list-parity-enhancements/[email protected]>
  Branch: refs/heads/jira/NMS-20125-node-list-parity-enhancements
  Home:   https://github.com/OpenNMS/opennms
  Commit: 90bf450693a159e9f155d47b287dcccfd6618722
      https://github.com/OpenNMS/opennms/commit/90bf450693a159e9f155d47b287dcccfd6618722
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-03 (Mon, 03 Aug 2026)

  Changed paths:
    M ui/src/components/Nodes/NodesTable.vue
    M ui/src/components/Nodes/hooks/useNodeQuery.ts
    M ui/tests/components/Nodes/NodesTable.test.ts
    M ui/tests/components/Nodes/hooks/useNodeQuery.test.ts

  Log Message:
  -----------
  NMS-20125: validate node search input and correct wildcard help text


  Commit: c00ca41aab06d013cf29f9deef2baf514588c223
      https://github.com/OpenNMS/opennms/commit/c00ca41aab06d013cf29f9deef2baf514588c223
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-03 (Mon, 03 Aug 2026)

  Changed paths:
    M ui/src/components/Nodes/NodesTable.vue
    M ui/tests/components/Nodes/NodesTable.test.ts

  Log Message:
  -----------
  NMS-20125: re-validate injected search terms in the queryFilter watch

The queryFilter watch in NodesTable.vue was unconditionally clearing
searchError whenever it resynced currentSearch from the store, on the
false assumption that the store's searchTerm is always valid. It is
not: nodeStructureStore.setFromNodePreferences writes an unvalidated
searchTerm straight into queryFilter from the URL nodename param and
from restored localStorage preferences, bypassing searchFilterHandler
entirely. Re-validate instead of unconditionally clearing, so an
injected invalid term is surfaced as a visible error; the existing
buildNodeStructureQuery guard already keeps the actual request safe.


Compare: https://github.com/OpenNMS/opennms/compare/0c8a3d4fd10b...c00ca41aab06

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs