[OpenNMS/opennms] 1394a3: NMS-20125: snmpParm takes priority over maclike in...

  Branch: refs/heads/jira/NMS-20125-node-list-parity-enhancements
  Home:   https://github.com/OpenNMS/opennms
  Commit: 1394a37f763c194d5f1f89c7fac488d2f634c8f8
      https://github.com/OpenNMS/opennms/commit/1394a37f763c194d5f1f89c7fac488d2f634c8f8
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-04 (Tue, 04 Aug 2026)

  Changed paths:
    M ui/src/components/Nodes/hooks/useInterfaceListing.ts
    M ui/tests/components/Nodes/hooks/useInterfaceListing.test.ts

  Log Message:
  -----------
  NMS-20125: snmpParm takes priority over maclike in interface listing, matching legacy

DefaultNodeListService#createModelForNodes checks hasSnmpParm() before
hasMaclike(), but getInterfaceListMode() checked macAddress first and its
JSDoc claimed the opposite priority. Reorder the checks so an SNMP
ifAlias/ifName/ifDescr filter wins when both it and a MAC filter are set,
and pin the fall-through (multiple SNMP fields -> maclike) with a test.


  Commit: aabf3e776c2b9945bac856d9c7cf5c566e7705d7
      https://github.com/OpenNMS/opennms/commit/aabf3e776c2b9945bac856d9c7cf5c566e7705d7
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-04 (Tue, 04 Aug 2026)

  Changed paths:
    M ui/src/components/Nodes/hooks/useNodeQuery.ts
    M ui/tests/components/Nodes/hooks/useNodeQuery.test.ts

  Log Message:
  -----------
  NMS-20125: remove unused getNodeIdRedirect(), point nodeId NOTE at the live redirect path

getNodeIdRedirect() had no production callers: handleNodeIdRedirect() in
Nodes.vue needs the parsed id on its own to defer the redirect until
mainMenu loads, so the combinator can't express the live flow. Delete it
(and its redundant unit tests; parseNodeIdQueryParam/buildNodeDetailUrl
keep their direct coverage) and fix the NOTE comment that pointed to it.


  Commit: 2cddfa189ec8b0db25392866e9df3927d93d24ec
      https://github.com/OpenNMS/opennms/commit/2cddfa189ec8b0db25392866e9df3927d93d24ec
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-04 (Tue, 04 Aug 2026)

  Changed paths:
    M ui/src/services/ipInterfaceService.ts
    M ui/src/services/snmpInterfaceService.ts
    A ui/tests/services/ipInterfaceService.test.ts

  Log Message:
  -----------
  NMS-20125: fix FIQL precedence in getNodeIpInterfaceQuery via the two-group form

FIQL ';' (AND) binds tighter than ',' (OR), so the single-group form
'(node.id==1,node.id==2;isManaged==M)' bound isManaged to only the last
node id, returning unmanaged interfaces for every node but the last when
managedOnly was requested. Use the same '(ids);(term)' two-group shape as
getNodeSnmpInterfaceQuery (whose comment contrasting the two shapes is
updated accordingly), and add tests pinning the query shape.


  Commit: 5b6a1d7fb109c0cd98913b9f7f9229d807fb4afc
      https://github.com/OpenNMS/opennms/commit/5b6a1d7fb109c0cd98913b9f7f9229d807fb4afc
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-04 (Tue, 04 Aug 2026)

  Changed paths:
    M ui/src/components/Nodes/NodesTable.vue
    M ui/src/stores/nodeStore.ts
    M ui/tests/stores/nodeStore.test.ts

  Log Message:
  -----------
  NMS-20125: sequence getSnmpInterfacesForNodes requests so the latest always wins

The SNMP interface fetch had no request sequencing: overlapping calls
raced and whichever response landed last replaced nodeToSnmpInterfaceMap,
so a slow stale response could clobber a newer result (or an empty-ids
reset). Guard with a monotonic request id — a response is discarded if a
newer call started after its request was issued — and update the
NodesTable.vue watcher-gating comment that relied on the absence of
sequencing for its reasoning. Tests drive both stale-response scenarios.


Compare: https://github.com/OpenNMS/opennms/compare/60ac0654b4d3...5b6a1d7fb109

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs