[OpenNMS/opennms] 5d2d97: NMS-20100 : address review — seam-declared API for ...
joseanesONMS via opennms-cvs <[email protected]>
| Newsgroups | gmane.network.opennms.cvs |
|---|---|
| Message-ID | <OpenNMS/opennms/push/refs/heads/jira/NMS-20100-notifications-page/[email protected]> |
Branch: refs/heads/jira/NMS-20100-notifications-page
Home: https://github.com/OpenNMS/opennms
Commit: 5d2d97719b580bf21964620122a97da3090f54d9
https://github.com/OpenNMS/opennms/commit/5d2d97719b580bf21964620122a97da3090f54d9
Author: Jose Anes <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
M ui/src/components/AdminNotifications/NoticesTable.vue
M ui/src/components/AdminNotifications/NotificationQueriesCard.vue
Log Message:
-----------
NMS-20100: address review — seam-declared API for icon buttons, dialog sizing, table loading
Per review: the user-search / notice-detail icon-only buttons in
NotificationQueriesCard use OnmsIconButton with a Search icon component
instead of OnmsButton with a fallthrough icon="pi pi-search";
ConfigureNotificationsDialog routes sizing through the OnmsDialog width prop
(min(1100px, 95vw)) and drops maximizable, which the seam does not expose;
NoticesTable drops :loading, which OnmsTable does not declare. Removes the
$attrs reliance the seam exists to prevent.
To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list
To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs