[OpenNMS/opennms] ede67e: NMS-20118: expand Add Event Notification modal

  Branch: refs/heads/jira/NMS-20118-event-notifications
  Home:   https://github.com/OpenNMS/opennms
  Commit: ede67e9012b414bffe8a8a41347de6d8443571af
      https://github.com/OpenNMS/opennms/commit/ede67e9012b414bffe8a8a41347de6d8443571af
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: expand Add Event Notification modal

Surface the notification fields the single modal was silently preserving:
an Advanced options disclosure with the notification parameters (name/value
repeater), varbind, event-severity and notice-queue. Lead with a full-width
Event UEI selector that shows each event's friendly label above its UEI, and
add '?' help for the Rule and the (confusing) Numeric Message field. Seed the
legacy subject/numeric defaults.


  Commit: ca3a78cc14a8721c4bdfdaad2ca2be334cc1f4b0
      https://github.com/OpenNMS/opennms/commit/ca3a78cc14a8721c4bdfdaad2ca2be334cc1f4b0
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/types/notificationConfig.ts

  Log Message:
  -----------
  NMS-20118: rule builder and validation for event notifications

Add a Builder/Raw rule editor to the Add Event Notification modal: the
Builder assembles the filter from an IP-address filter plus Services (OR)
and excluded-Services (NOT) pickers the way the legacy wizard did, round-
trips an existing rule back into the controls where it can, and a Validate
button previews the matching interfaces/services. Backed by two new
webapp-rest endpoints — a service list and a FilterDao-based rule preview.
Also refine the numeric-message help wording.


  Commit: 1dfb794dcf0ca2d172fad77e8bdca51704e3fcaf
      https://github.com/OpenNMS/opennms/commit/1dfb794dcf0ca2d172fad77e8bdca51704e3fcaf
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: single rule field, wider modal, pager wording

Merge the standalone Rule field and the builder into one Rule block so the
two can't diverge — Builder drives the rule via the pickers, Raw edits it
directly, and switching to Builder falls back to Raw when the rule is too
advanced to represent. Widen the modal and label the numeric message as a
pager field.


  Commit: d6050b8f841258d6e66fa86f476cd52838481163
      https://github.com/OpenNMS/opennms/commit/d6050b8f841258d6e66fa86f476cd52838481163
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: let the rule builder round-trip hyphenated service names

The Raw->Builder parse used is\w+, which stops at the hyphen in service
names like OpenNMS-DB, so those rules were wrongly flagged too advanced and
stuck in Raw. Match is[\w.-]+ so they round-trip into the pickers.


  Commit: 1442adba1f8d6839d0c201104e924d01c13c2f59
      https://github.com/OpenNMS/opennms/commit/1442adba1f8d6839d0c201104e924d01c13c2f59
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: fix dark-mode contrast of the generated-rule preview

The preview used --p-surface-100 as a background, which is dark in dark mode
and left the rule text nearly unreadable. Drop the fill for a border and
theme-aware text tokens so it reads in both themes.


  Commit: 6d39a93cdb7c748217cead2943922cedcde25557
      https://github.com/OpenNMS/opennms/commit/6d39a93cdb7c748217cead2943922cedcde25557
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: harden Add Event Notification validation

Add inline field validation with messages (name required + 255-char cap +
duplicate-name check, UEI required + ~regex validity, destination path, text
message), length caps on the text inputs, rule-syntax validation on save
(client via the validate endpoint, server via FilterDao), an in-dialog error
banner instead of a modal-hidden toast, and server-side varbind validation.


Compare: https://github.com/OpenNMS/opennms/compare/2809a13f2358...6d39a93cdb7c

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs