[OpenNMS/opennms] ec0e93: NMS-20124: point the notification bell at the new ...

joseanesONMS via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20124-bell-notifications/[email protected]>
  Branch: refs/heads/jira/NMS-20124-bell-notifications
  Home:   https://github.com/OpenNMS/opennms
  Commit: ec0e937c8b1454bf625689e4a7b8f8d64ba91fe3
      https://github.com/OpenNMS/opennms/commit/ec0e937c8b1454bf625689e4a7b8f8d64ba91fe3
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationRestService.java
    M opennms-webapp-rest/src/main/webapp/WEB-INF/menu/menu-template.json
    M ui/src/components/AdminNotifications/NotificationQueriesCard.vue
    M ui/src/components/Menu/UserNotificationsMenuItem.vue
    M ui/src/containers/Notifications.vue
    M ui/src/services/noticesService.ts
    M ui/src/stores/noticesStore.ts
    M ui/src/types/notices.ts
    M ui/tests/stores/noticesStore.test.ts

  Log Message:
  -----------
  NMS-20124: point the notification bell at the new Notifications page

The bell dropdown links now land on the Vue Notifications page with the
matching preset applied, and the status row opens the page that hosts the
configuration dialog. The dropdown says notifications instead of notices,
matching the page.

The team row gets a real filter: a new excludeNotifiedUser parameter on
the v1 notifications list applies the same criteria the summary endpoint
uses for its team count (notified users other than you, or nobody), and
the page exposes it as a fourth query preset, so the bell's 'N of M
assigned to anyone but you' lands on exactly those N.


  Commit: 6005c114aee1e497f257370c54ddb06e2fc3fc4e
      https://github.com/OpenNMS/opennms/commit/6005c114aee1e497f257370c54ddb06e2fc3fc4e
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:

  Log Message:
  -----------
  NMS-20124: re-trigger CI (flaky smoke-test-minion infra timeout)


  Commit: b07529a7e6e598cf76fe8b484f9c6b6776252226
      https://github.com/OpenNMS/opennms/commit/b07529a7e6e598cf76fe8b484f9c6b6776252226
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationRestService.java
    M ui/src/components/Menu/UserNotificationsMenuItem.vue
    M ui/src/containers/Notifications.vue

  Log Message:
  -----------
  NMS-20124: bell notices deep-link to the filtered page, in-page refresh, dark mode, and query correctness

Clicking a specific notice in the bell now opens the new Notifications
page filtered to the user's outstanding notices instead of the legacy
notification/detail.jsp. Re-apply the preset on route-query change so a
bell click while already on the page refreshes the list (the component
is not remounted on a hash-query change).

Fix the teamOutstanding ("assigned to anyone but you") query: the
usersNotified LEFT_JOIN with or(ne,isNull) duplicated notices and
inflated the count, so mark the criteria distinct; and always consume a
blank excludeNotifiedUser param so it is not mis-parsed as an entity
property (was a 500). Add a dark-mode text fix for the notifications
page and its dialogs, keyed off the reliable html.open-dark class since
the PrimeVue dark tokens do not reach the custom/teleported text.


  Commit: 17923079cd6b5a1cb22d5a95de10a8cd289a15a6
      https://github.com/OpenNMS/opennms/commit/17923079cd6b5a1cb22d5a95de10a8cd289a15a6
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/containers/Notifications.vue

  Log Message:
  -----------
  NMS-20124: fix white notification dialog panels in dark mode

PrimeVue's dialog chrome does not follow the dark tokens in this build, so
the panel stayed light while the content and fields went dark (no contrast),
and the earlier text-only fix left light text on a white panel. The
notification dialog classes never land on the teleported .p-dialog root, so
target .p-dialog directly and pin the panel/header/content/footer to the dark
surface, forcing the title, labels and header icons light.


  Commit: 978f1c87473bf0ff2e9902cf1843ecea7c86b48d
      https://github.com/OpenNMS/opennms/commit/978f1c87473bf0ff2e9902cf1843ecea7c86b48d
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/containers/Notifications.vue

  Log Message:
  -----------
  NMS-20124: drop the inline dark-mode CSS band-aid; team-aware export

Remove the non-scoped html.open-dark / .p-dialog override from Notifications.vue
(the base's OnmsDialog + theme handle dark mode now; a residual global gap
belongs in its own theme PR, per review). Also carry excludeUser through
fetchForExport so a teamOutstanding export stays scoped.


Compare: https://github.com/OpenNMS/opennms/compare/d85968026ad0...978f1c87473b

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.