[OpenNMS/opennms] e328f3: NMS-20026: Fix TicketNotificationStrategy wiring

mershad-manesh via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/merge-foundation/foundation-2023-to-foundation-2024/[email protected]> 
  Branch: refs/heads/merge-foundation/foundation-2023-to-foundation-2024
  Home:   https://github.com/OpenNMS/opennms
  Commit: e328f31dee837e1637cfcc5f63f6174004829776
      https://github.com/OpenNMS/opennms/commit/e328f31dee837e1637cfcc5f63f6174004829776
  Author: Chandra Gorantla <[email protected]>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
    M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java

  Log Message:
  -----------
  NMS-20026: Fix TicketNotificationStrategy wiring


  Commit: 3fe2678de6f6ef8bfdfd9fd57a4b9ba746eb8230
      https://github.com/OpenNMS/opennms/commit/3fe2678de6f6ef8bfdfd9fd57a4b9ba746eb8230
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-29 (Wed, 29 Jul 2026)

  Changed paths:
    M docs/modules/operation/nav.adoc
    M docs/modules/operation/pages/deep-dive/notifications/bonus-strategies.adoc
    A docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
    M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
    M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
    M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
    M opennms-base-assembly/src/main/filtered/etc/examples/notificationCommands.xml

  Log Message:
  -----------
  NMS-20101: Make TicketNotificationStrategy usable and document it

The strategy shipped with no reference in any notificationCommands.xml,
so it was unreachable without hand-written configuration, and its
delivery-time alarm lookup fails when a destination path fires before
alarmd has associated the event with an alarm.

Adds a createTicket example command and a Create-Ticket example
destination path with a non-zero initial-delay to work around the
alarmd race, plus a strategy page in the notifications docs covering
the prerequisites and caveats.

Replaces the hardcoded admin ticket user with an optional ticketUser
argument that can be set per notification; absent or blank values fall
back to admin, preserving the previous behavior.


  Commit: 7577c600430af0aa4b84c5ff5cdd9eab9df26da4
      https://github.com/OpenNMS/opennms/commit/7577c600430af0aa4b84c5ff5cdd9eab9df26da4
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-29 (Wed, 29 Jul 2026)

  Changed paths:
    M docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
    M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
    M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml

  Log Message:
  -----------
  NMS-20101: Address review feedback

Adds the missing space in the send() info log message, corrects the
stale copy-pasted javadoc on getAlarmTypeFromUEI, and makes the
target wording in the docs and example comment agnostic to whether
the destination path targets a user or a group.


  Commit: 6182b206b041eee69a561655c2046abe58b4da6f
      https://github.com/OpenNMS/opennms/commit/6182b206b041eee69a561655c2046abe58b4da6f
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-29 (Wed, 29 Jul 2026)

  Changed paths:
    M core/grpc/osgi/pom.xml
    M core/ipc/grpc/itests/pom.xml
    M core/ipc/rpc/api/src/main/java/org/opennms/core/rpc/api/RpcExceptionUtils.java
    M core/ipc/rpc/camel/src/main/java/org/opennms/core/rpc/camel/CamelRpcClientFactory.java
    M core/ipc/rpc/camel/src/test/java/org/opennms/core/rpc/camel/LocalRpcTimeoutTest.java
    M core/ipc/twin/grpc/itests/pom.xml
    M core/ipc/twin/kafka/itests/pom.xml
    A core/mate/api/src/main/java/org/opennms/core/mate/api/LazyScope.java
    A core/mate/api/src/test/java/org/opennms/core/mate/api/LazyScopeTest.java
    M docs/modules/deployment/pages/core/getting-started.adoc
    M docs/modules/reference/pages/configuration/ttl-rpc.adoc
    M features/collection/client-rpc/src/main/resources/META-INF/opennms/applicationContext-rpc-collector.xml
    A features/collection/client-rpc/src/test/java/org/opennms/netmgt/collection/client/rpc/CollectorExecutorLifecycleTest.java
    M features/collection/thresholding/impl/src/main/java/org/opennms/netmgt/threshd/ThresholdEntity.java
    M features/collection/thresholding/impl/src/main/java/org/opennms/netmgt/threshd/ThresholdingSetImpl.java
    M features/collection/thresholding/impl/src/main/java/org/opennms/netmgt/threshd/ThresholdingVisitorImpl.java
    M features/minion/core/repository/src/assembly/repo.xml
    M features/minion/repository/src/assembly/repo.xml
    M features/poller/client-rpc/src/main/java/org/opennms/netmgt/poller/client/rpc/PollerRequestBuilderImpl.java
    M features/poller/client-rpc/src/main/resources/META-INF/opennms/applicationContext-rpc-poller.xml
    A features/poller/client-rpc/src/test/java/org/opennms/netmgt/poller/client/rpc/PollerExecutorLifecycleTest.java
    M features/scv/dominion-grpc-impl/pom.xml
    M features/telemetry/protocols/openconfig/itests/pom.xml
    M opennms-container/common.mk
    M opennms-container/core/Dockerfile
    M opennms-container/minion/Dockerfile
    M opennms-container/sentinel/Dockerfile
    M opennms-provision/opennms-provisiond/src/main/java/org/opennms/netmgt/provision/service/NodeScan.java
    M opennms-provision/opennms-provisiond/src/test/java/org/opennms/netmgt/provision/service/ProvisionerIT.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DiscoveryRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/DiscoveryRestServiceIT.java
    M opennms-webapp/src/main/webapp/WEB-INF/applicationContext-spring-security.xml
    M pom.xml
    M smoke-test/src/main/java/org/opennms/smoketest/containers/MockCloudContainer.java
    M smoke-test/src/main/java/org/opennms/smoketest/selenium/AbstractOpenNMSSeleniumHelper.java

  Log Message:
  -----------
  Merge remote-tracking branch 'upstream/foundation-2024' into mm/NMS-20101-smoke

# Conflicts:
#	features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java


  Commit: 224a50e5ff78c9923bc721d19fa9f9eae48f2b7d
      https://github.com/OpenNMS/opennms/commit/224a50e5ff78c9923bc721d19fa9f9eae48f2b7d
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-29 (Wed, 29 Jul 2026)

  Changed paths:
    M docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
    M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
    M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
    M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml

  Log Message:
  -----------
  NMS-20101: Skip ticket creation when the alarm already has a ticket

A group destination path target runs the createTicket command once per
member, and repeat notifications or escalations re-run it for the same
alarm; the ticketer creates a new ticket on every create event, so each
run produced another ticket.

Uses the tticketid the strategy already fetches to skip the create
event when the alarm has a ticket.  Near-simultaneous deliveries can
still race the asynchronous ticket creation, so the examples and docs
now recommend a single-user target instead of a group.


  Commit: bbc2aaf3bbaa2a225ce2337c3880469dc7ff3aed
      https://github.com/OpenNMS/opennms/commit/bbc2aaf3bbaa2a225ce2337c3880469dc7ff3aed
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-30 (Thu, 30 Jul 2026)

  Changed paths:
    M docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
    M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
    M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java

  Log Message:
  -----------
  NMS-20101: Only skip ticket creation while the alarm's ticket is active

Tickets that are closed, resolved, or cancelled, or whose creation
failed, no longer block a new ticket, so a re-fired problem can open a
fresh one.  Unknown state values stay on the blocking side, which also
covers a NULL tticketstate reading as 0 (OPEN) through JDBC getInt().
The comparison uses TroubleTicketState.getValue(), which matches the
ordinal the database stores for every current constant.

Allowing a retry after CREATE_FAILED goes beyond the alarmd drools
rules, which only create when the state is null; for a
notification-driven path a failed create should not permanently block
the channel.

Also returns a clean error instead of an NPE when the event row no
longer exists, and adds a point-of-use docs note recommending
single-user targets.


  Commit: a6962a26ac9ebd88808599fc65e18500433f8d85
      https://github.com/OpenNMS/opennms/commit/a6962a26ac9ebd88808599fc65e18500433f8d85
  Author: Christian Pape <[email protected]>
  Date:   2026-07-30 (Thu, 30 Jul 2026)

  Changed paths:
    M dependencies/activemq/pom.xml

  Log Message:
  -----------
  NMS-20089: Fixing tests


  Commit: c91d0b2d953d939daae06e205bcf4710d7543b4e
      https://github.com/OpenNMS/opennms/commit/c91d0b2d953d939daae06e205bcf4710d7543b4e
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-30 (Thu, 30 Jul 2026)

  Changed paths:
    M docs/modules/operation/nav.adoc
    M docs/modules/operation/pages/deep-dive/notifications/bonus-strategies.adoc
    A docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
    M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
    M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
    M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
    M opennms-base-assembly/src/main/filtered/etc/examples/notificationCommands.xml

  Log Message:
  -----------
  Merge pull request #8691 from OpenNMS/mm/NMS-20101-smoke

NMS-20101: Make TicketNotificationStrategy usable and document it


  Commit: 4fb713db8a61f5d91495ec9e595e5e53469b6a6e
      https://github.com/OpenNMS/opennms/commit/4fb713db8a61f5d91495ec9e595e5e53469b6a6e
  Author: Chandra Gorantla <[email protected]>
  Date:   2026-07-30 (Thu, 30 Jul 2026)

  Changed paths:
    M opennms-container/core/container-fs/health.sh

  Log Message:
  -----------
  NMS-20116: Fix container health.sh (#8704)


  Commit: 8c1624d92ad57ffed7dbfd1d205813fac2f92c7b
      https://github.com/OpenNMS/opennms/commit/8c1624d92ad57ffed7dbfd1d205813fac2f92c7b
  Author: Chandra Gorantla <[email protected]>
  Date:   2026-08-03 (Mon, 03 Aug 2026)

  Changed paths:
    M docs/modules/operation/pages/deep-dive/notifications/strategies/ticket.adoc
    M features/notifications/ticket-strategy/src/main/java/org/opennms/netmgt/notifd/TicketNotificationStrategy.java
    M features/notifications/ticket-strategy/src/test/java/org/opennms/netmgt/notifd/TicketNotificationStrategyTest.java
    M opennms-base-assembly/src/main/filtered/etc/examples/destinationPaths.xml
    M opennms-base-assembly/src/main/filtered/etc/examples/notificationCommands.xml

  Log Message:
  -----------
  NMS-20105: Close the trouble ticket when the alarm clears (#8720)

* NMS-20105: Close the trouble ticket when the alarm clears

The notification command now sends a close for a cleared alarm that still has an
active ticket, instead of creating another one, so the resolution delivery
completes the workflow. Renames the example command to troubleTicket.

* NMS-20105: Address review comments


  Commit: 345d4513c20fc2b7c60ce900b5b73a2eeffa4ced
      https://github.com/OpenNMS/opennms/commit/345d4513c20fc2b7c60ce900b5b73a2eeffa4ced
  Author: Morteza E <[email protected]>
  Date:   2026-08-04 (Tue, 04 Aug 2026)

  Changed paths:
    M opennms-container/common.mk
    M opennms-container/core/Dockerfile
    M opennms-container/minion/Dockerfile
    M opennms-container/sentinel/Dockerfile
    M smoke-test/src/main/java/org/opennms/smoketest/containers/MockCloudContainer.java

  Log Message:
  -----------
  Update base image


  Commit: d361c17677477314374224afc50585d7404aae4a
      https://github.com/OpenNMS/opennms/commit/d361c17677477314374224afc50585d7404aae4a
  Author: Christian Pape <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M container/karaf/pom.xml
    M container/karaf/src/main/internal/features-processing.xml
    M container/shared/pom.xml
    M container/shared/src/main/internal/features-processing.xml
    M features/minion/repository/pom.xml
    M features/sentinel/repository/pom.xml
    M opennms-full-assembly/pom.xml
    M opennms-full-assembly/src/assembly/components/osgi.xml
    M pom.xml

  Log Message:
  -----------
  NMS-20061: Use jline version 3.30.16


  Commit: 3e8957b13a9d1956b033e6ac4569d38be53f964b
      https://github.com/OpenNMS/opennms/commit/3e8957b13a9d1956b033e6ac4569d38be53f964b
  Author: Dino <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M container/features/pom.xml
    M container/features/src/main/resources/features-sentinel.xml
    M container/features/src/main/resources/features.xml
    M features/sentinel/repository/pom.xml

  Log Message:
  -----------
  NMS-20164: Lock OSGi resolved dependencies to the root pom versions (#8741)

* NMS-20164: Lock OSGi resolved dependencies to the root pom versions


  Commit: ced46e5dc09ebb62313c79f1fb58249aec7e3bd3
      https://github.com/OpenNMS/opennms/commit/ced46e5dc09ebb62313c79f1fb58249aec7e3bd3
  Author: mershad-manesh <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M .circleci/README.md
    M .circleci/epoch
    M .circleci/main/jobs/tests/integration/integration-test.yml
    M .circleci/main/parameters.yml
    M .circleci/main/workflows/workflows_v2.json
    M .circleci/pyscripts/library/cci_components/workflow.py
    M .circleci/pyscripts/process_generate.py

  Log Message:
  -----------
  NMS-20104: Add ability to run full integration tests on CircleCI (#8694)

* Allow the user to run a full integration test build

* test what happens when we give !integration

* Update the readme file to add the new integration option


  Commit: 91ab0941c84716d31f9b84a0c87c8d1365ffe941
      https://github.com/OpenNMS/opennms/commit/91ab0941c84716d31f9b84a0c87c8d1365ffe941
  Author: Morteza E <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M .circleci/README.md
    M .circleci/main/jobs/tests/integration/integration-test.yml
    M .circleci/main/parameters.yml
    M .circleci/main/workflows/workflows_v2.json
    M .circleci/pyscripts/library/cci_components/workflow.py
    M .circleci/pyscripts/process_generate.py
    M container/features/pom.xml
    M container/features/src/main/resources/features-sentinel.xml
    M container/features/src/main/resources/features.xml
    M features/sentinel/repository/pom.xml

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/foundation-2023' into foundation-2024


Compare: https://github.com/OpenNMS/opennms/compare/5e003e7e5438...91ab0941c847

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.