[OpenNMS/opennms] c74744: NMS-20118: restore the UEI type-ahead's event-labe...

  Branch: refs/heads/jira/NMS-20118-event-notifications
  Home:   https://github.com/OpenNMS/opennms
  Commit: c74744b282d9557c73725dd5b69cc72523c4ebde
      https://github.com/OpenNMS/opennms/commit/c74744b282d9557c73725dd5b69cc72523c4ebde
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/packages/onms-ui/src/components/OnmsAutoComplete.vue
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: restore the UEI type-ahead's event-label option rendering

OnmsAutoComplete did not forward PrimeVue AutoComplete's #option slot, so
the seam migration had to drop the UEI suggestions' two-line template and
they rendered as the bare UEI. Forward the #option slot in the wrapper and
restore the slot so each suggestion shows the UEI plus its event label.


  Commit: 970e5fff5263b89a1066e827da9069f395b06f83
      https://github.com/OpenNMS/opennms/commit/970e5fff5263b89a1066e827da9069f395b06f83
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: expand Add Event Notification modal

Surface the notification fields the single modal was silently preserving:
an Advanced options disclosure with the notification parameters (name/value
repeater), varbind, event-severity and notice-queue. Lead with a full-width
Event UEI selector that shows each event's friendly label above its UEI, and
add '?' help for the Rule and the (confusing) Numeric Message field. Seed the
legacy subject/numeric defaults.


  Commit: a10f7783893074f113212878ee797f3667f6edea
      https://github.com/OpenNMS/opennms/commit/a10f7783893074f113212878ee797f3667f6edea
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/types/notificationConfig.ts

  Log Message:
  -----------
  NMS-20118: rule builder and validation for event notifications

Add a Builder/Raw rule editor to the Add Event Notification modal: the
Builder assembles the filter from an IP-address filter plus Services (OR)
and excluded-Services (NOT) pickers the way the legacy wizard did, round-
trips an existing rule back into the controls where it can, and a Validate
button previews the matching interfaces/services. Backed by two new
webapp-rest endpoints — a service list and a FilterDao-based rule preview.
Also refine the numeric-message help wording.


  Commit: 76a4489ad2518968ccc5e6a8dc398252623d3bc3
      https://github.com/OpenNMS/opennms/commit/76a4489ad2518968ccc5e6a8dc398252623d3bc3
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: single rule field, wider modal, pager wording

Merge the standalone Rule field and the builder into one Rule block so the
two can't diverge — Builder drives the rule via the pickers, Raw edits it
directly, and switching to Builder falls back to Raw when the rule is too
advanced to represent. Widen the modal and label the numeric message as a
pager field.


  Commit: 426ca542503a1d2cdf2ff55e12947bff2f17eecc
      https://github.com/OpenNMS/opennms/commit/426ca542503a1d2cdf2ff55e12947bff2f17eecc
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: let the rule builder round-trip hyphenated service names

The Raw->Builder parse used is\w+, which stops at the hyphen in service
names like OpenNMS-DB, so those rules were wrongly flagged too advanced and
stuck in Raw. Match is[\w.-]+ so they round-trip into the pickers.


  Commit: b6d3fa4a9ec0c37055ed106613c7362e49f6543e
      https://github.com/OpenNMS/opennms/commit/b6d3fa4a9ec0c37055ed106613c7362e49f6543e
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: fix dark-mode contrast of the generated-rule preview

The preview used --p-surface-100 as a background, which is dark in dark mode
and left the rule text nearly unreadable. Drop the fill for a border and
theme-aware text tokens so it reads in both themes.


  Commit: 558b011fd0f5bc694f0abee8223a1e716720daa0
      https://github.com/OpenNMS/opennms/commit/558b011fd0f5bc694f0abee8223a1e716720daa0
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: harden Add Event Notification validation

Add inline field validation with messages (name required + 255-char cap +
duplicate-name check, UEI required + ~regex validity, destination path, text
message), length caps on the text inputs, rule-syntax validation on save
(client via the validate endpoint, server via FilterDao), an in-dialog error
banner instead of a modal-hidden toast, and server-side varbind validation.


  Commit: e0a5978d4211368b47aee1ecba7cc5449bb59bed
      https://github.com/OpenNMS/opennms/commit/e0a5978d4211368b47aee1ecba7cc5449bb59bed
  Author: Jose Anes <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M ui/packages/onms-ui/src/components/OnmsMultiSelect.vue
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue

  Log Message:
  -----------
  NMS-20118: label rule pickers via inputId and fix rule builder edge cases

Add inputId to the OnmsMultiSelect seam and forward it to PrimeVue, then
use it (with the OnmsSelect controls) so the paired <label for> associates
instead of landing on a dead labelid attribute. Also group the IP filter
with a real single-enclosing-paren check so an OR'd filter keeps its
grouping when a service clause is appended, and match leftover service
clauses in parseRule as whole words so filters containing dist/list/history
are no longer refused by the builder.


Compare: https://github.com/OpenNMS/opennms/compare/4b337cba9744...e0a5978d4211

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs