[OpenNMS/opennms] ad4c2a: NMS-20163: Check ReST coverage per module rather t...
Marshall Massengill via opennms-cvs <[email protected]>
| Newsgroups | gmane.network.opennms.cvs |
|---|---|
| Message-ID | <OpenNMS/opennms/push/refs/heads/mm/NMS-20163-smoke/[email protected]> |
Branch: refs/heads/mm/NMS-20163-smoke
Home: https://github.com/OpenNMS/opennms
Commit: ad4c2a69ba4e9daf6307e3ea2dba91530ad7e010
https://github.com/OpenNMS/opennms/commit/ad4c2a69ba4e9daf6307e3ea2dba91530ad7e010
Author: Marshall Massengill <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M opennms-openapi-docs/src/test/java/org/opennms/openapi/OpenApiResourceCoverageTest.java
Log Message:
-----------
NMS-20163: Check ReST coverage per module rather than per class
@Path is often inherited from an interface in org.opennms.web.rest.v2.api,
which reading the class declaration in source cannot see; six resources were
being skipped. Checking that each module contributing ReST sources resolves
on the classpath needs no annotation parsing and is what catches a missing
dependency.
Locate the repository root by walking up for a marker, so moving this module
does not silently break the scan. -Dopennms.repoRoot overrides it.
Commit: 3d707083217980eb829aa6bb0a9f2a58af5f7161
https://github.com/OpenNMS/opennms/commit/3d707083217980eb829aa6bb0a9f2a58af5f7161
Author: Marshall Massengill <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M opennms-openapi-docs/pom.xml
M opennms-openapi-docs/src/main/java/org/opennms/openapi/OpenApiDocWriter.java
M opennms-openapi-docs/src/test/java/org/opennms/openapi/OpenApiDocsContentTest.java
M opennms-openapi-docs/src/test/java/org/opennms/openapi/OpenApiResourceCoverageTest.java
Log Message:
-----------
NMS-20163: Refuse to generate the documents outside a forked JVM
Run by exec:java rather than exec:exec, the generator is loaded by a plugin
realm, part of the project classpath is shadowed, and one schema silently
loses its xml metadata while every test still passes. Check the class loader
and fail instead.
Also resolve the java executable per platform, drop the environment-specific
directory from the source scan in favour of skipping dot directories, allow a
module to be exempted from the coverage check, and raise the path-count floors
from 150 against actual counts of 199 and 223.
Compare: https://github.com/OpenNMS/opennms/compare/244866a57f9f...3d7070832179
To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list
To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs