[OpenNMS/opennms] 56d259: NMS-18217: address PR review feedback
Scott Theleman via opennms-cvs <[email protected]>
| Newsgroups | gmane.network.opennms.cvs |
|---|---|
| Message-ID | <OpenNMS/opennms/push/refs/heads/jira/NMS-18217-remove-legacy-nodelist-page-smoke/[email protected]> |
Branch: refs/heads/jira/NMS-18217-remove-legacy-nodelist-page-smoke
Home: https://github.com/OpenNMS/opennms
Commit: 56d259540329efc2600cbe2c5cd5cc6b7228274c
https://github.com/OpenNMS/opennms/commit/56d259540329efc2600cbe2c5cd5cc6b7228274c
Author: Scott Theleman <[email protected]>
Date: 2026-08-07 (Fri, 07 Aug 2026)
Changed paths:
M features/springframework-security/src/test/java/org/opennms/web/springframework/security/LoginModuleUtilsTest.java
M opennms-webapp/src/main/java/org/opennms/web/element/ElementIdNotFoundException.java
M smoke-test/src/main/java/org/opennms/smoketest/selenium/AbstractOpenNMSSeleniumHelper.java
M smoke-test/src/test/java/org/opennms/smoketest/ProvisioningNewUIIT.java
Log Message:
-----------
NMS-18217: address PR review feedback
- Drop the dead nodePage() call in ProvisioningNewUIIT (immediately
overwritten by direct node-detail navigation) and remove the now
caller-less nodePage() helper
- Replace the last /element/nodeList.htm reference (stale example URL
in LoginModuleUtilsTest) with a surviving page
- Fix pre-existing ElementIdNotFoundException bug: the 6-arg
constructor accepted browseUri but never assigned it, so the
'browse the node list' link on the element-id-not-found error page
never rendered for those call sites
Commit: ad90d6865c2e52b67a0f1a457106468506812d23
https://github.com/OpenNMS/opennms/commit/ad90d6865c2e52b67a0f1a457106468506812d23
Author: Scott Theleman <[email protected]>
Date: 2026-08-07 (Fri, 07 Aug 2026)
Changed paths:
M ui/src/styles/opennms-styles.scss
Log Message:
-----------
NMS-18217: force light color-scheme for native checkboxes and radios on legacy pages
Extends the existing <select> fix: in dark mode PrimeVue sets
color-scheme: dark on the document, making native form controls render
dark on the light-only legacy JSP pages (e.g. the alarm list's Ack
checkboxes).
Compare: https://github.com/OpenNMS/opennms/compare/48d923954677...ad90d6865c2e
To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list
To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs