[OpenNMS/opennms] b9822b: NMS-20201: Address review findings on menubar resp...

Scott Theleman via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20201-make-top-menubar-more-responsive/[email protected]>
  Branch: refs/heads/jira/NMS-20201-make-top-menubar-more-responsive
  Home:   https://github.com/OpenNMS/opennms
  Commit: b9822b527d2c90ba12658a50d6c40da845befc4c
      https://github.com/OpenNMS/opennms/commit/b9822b527d2c90ba12658a50d6c40da845befc4c
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M ui/src/components/Menu/Menubar.vue
    M ui/src/components/Menu/Search.vue

  Log Message:
  -----------
  NMS-20201: Address review findings on menubar responsiveness

- Expose the compact date to assistive tech via OnmsIcon title
  (aria-label + role=img on the svg) instead of an unexposed aria-label
  on a role-less span; drop the tabindex, which was a focus stop that
  revealed nothing (PrimeVue's tooltip binds focus only with the .focus
  modifier, which would in turn drop hover)
- Suppress the tooltip until menu data loads: joined/filtered computed
  yields an empty (falsy) value, avoiding PrimeVue's untrimmed
  string-form blank tooltip
- Anchor the search results dropdown to the input's right edge so its
  24em floor grows leftward on-screen instead of past the viewport edge
- Cap the logo at 18rem so rebranded logos can't crowd out the bar now
  that the left column refuses to shrink below the logo
- Add 1em spacing between the search box and the date/calendar icon
- Lower the search floor from 12em to 10em to offset the added spacing
  and push the right-column overflow point closer to 600px


  Commit: f7658f1f9f06f4c26395107f960ecc43ee7976cb
      https://github.com/OpenNMS/opennms/commit/f7658f1f9f06f4c26395107f960ecc43ee7976cb
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M ui/src/components/Menu/Menubar.vue

  Log Message:
  -----------
  NMS-20201: Fix unreliable calendar-icon tooltip in fixed header

PrimeVue's tooltip directive captures the configured z-index (2100)
only when it mounts with a non-empty value; mounted with the empty
pre-load label, it fell back to z-index 1000 and painted behind the
fixed header (z-index 1030) whenever the default right-side placement
landed within the header band. Narrower viewports flipped the tooltip
below the bar, which is why it only sometimes appeared.

v-if the icon on the label so the directive mounts once data is
loaded, and place the tooltip below the bar with the .bottom modifier.


Compare: https://github.com/OpenNMS/opennms/compare/f007212156d5...f7658f1f9f06

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.