[OpenNMS/opennms] a68b32: NMS-20100: Event Notifications tab

  Branch: refs/heads/jira/NMS-20118-event-notifications
  Home:   https://github.com/OpenNMS/opennms
  Commit: a68b3297df3340acf4b13b8653c4f03be6dc3724
      https://github.com/OpenNMS/opennms/commit/a68b3297df3340acf4b13b8653c4f03be6dc3724
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    A ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    A ui/src/components/AdminNotifications/EventNotificationsTable.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/stores/notificationConfigStore.ts
    M ui/src/types/notificationConfig.ts
    M ui/tests/stores/notificationConfigStore.test.ts

  Log Message:
  -----------
  NMS-20100: Event Notifications tab

Add the Event Notifications tab: a table listing notifications with a
read-only status tag, icon actions and an overflow menu for enable/disable,
plus an editor dialog for the UEI, targets, rule and advanced parameters.
Fields use the FormField seam with inline info-icon help; long UEIs are
truncated so the table does not scroll horizontally.


  Commit: 2aa0f7b7e0ca29d14d598648f93f620494025175
      https://github.com/OpenNMS/opennms/commit/2aa0f7b7e0ca29d14d598648f93f620494025175
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    M ui/src/services/notificationConfigService.ts

  Log Message:
  -----------
  NMS-20118: only materialize the rule match preview on request; map infra errors correctly

Add a preview flag to the rule-validate endpoint so the save path pays only for
filterDao.validateRule; the full interface/service map is built solely for the
explicit match preview. Narrow the rule-validation catches to FilterParseException
so a malformed rule stays a user error while infrastructure failures propagate as
a 500 instead of a misleading 400.


  Commit: a88da025bc383931967d8d35a93e47e57bd5e34a
      https://github.com/OpenNMS/opennms/commit/a88da025bc383931967d8d35a93e47e57bd5e34a
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    M ui/src/components/AdminNotifications/EventNotificationsTable.vue
    M ui/src/types/notificationConfig.ts

  Log Message:
  -----------
  NMS-20118: address review findings on the event notification editor

Preserve an existing notification's rule verbatim on open (guard the builder-to-rule sync during population), reject blank parameter values before save, and skip service names that aren't legal filter identifiers when building the rule. Also correct the writeable type to boolean, render the add button icon via OnmsIcon instead of a raw PrimeIcons class.


  Commit: 81a71d4df04542e8308a77dbe8f3d3e5c0df4db0
      https://github.com/OpenNMS/opennms/commit/81a71d4df04542e8308a77dbe8f3d3e5c0df4db0
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java

  Log Message:
  -----------
  NMS-20118: IT coverage for the service list and rule validation endpoints

Add integration tests for GET /services and POST /rule/validate (including the
preview flag that gates the match-map materialization and a blank-rule
rejection), and extend the non-admin authorization test to the services, rule
validation, notification create and delete endpoints.


Compare: https://github.com/OpenNMS/opennms/compare/4d89da1a0550...81a71d4df045

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs