[OpenNMS/opennms] 03eb18: NMS-20107: make group rename atomic so a failed sa...

  Branch: refs/heads/jira/NMS-20107-manage-groups-primevue
  Home:   https://github.com/OpenNMS/opennms
  Commit: 03eb1887a5244495161dbdc9f807fd27c2eb1bf6
      https://github.com/OpenNMS/opennms/commit/03eb1887a5244495161dbdc9f807fd27c2eb1bf6
  Author: Jose Anes <[email protected]>
  Date:   2026-08-13 (Thu, 13 Aug 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/config/GroupManager.java
    A opennms-config/src/test/java/org/opennms/netmgt/config/GroupManagerRenameTest.java

  Log Message:
  -----------
  NMS-20107: make group rename atomic so a failed save leaves no phantom

GroupManager.renameGroup mutated the in-memory map (removed the old key, set
the new name, put the new key) before calling saveGroups(). If that save threw,
memory held the rename while groups.xml still held the old name, and the
mtime-gated update() would never re-read. GroupsRestService then read that
phantom through hasGroup(), mistook it for a persisted rename, reported the
wrong failure, and skipped its role rollback -- serving the phantom plus the
repointed roles until restart.

Roll the in-memory rename back when the save fails, so hasGroup() only ever
reports what groups.xml actually received and the caller's rollback runs on the
real failure. New GroupManagerRenameTest covers both the rolled-back and the
committed paths.


  Commit: 3626a369dfe5509e2a9f6c2d0bf62a45e169f4c9
      https://github.com/OpenNMS/opennms/commit/3626a369dfe5509e2a9f6c2d0bf62a45e169f4c9
  Author: Jose Anes <[email protected]>
  Date:   2026-08-13 (Thu, 13 Aug 2026)

  Changed paths:
    M ui/src/components/ManageGroups/GroupEditorDialog.vue
    M ui/src/components/ManageGroups/GroupRenameDialog.vue
    M ui/tests/components/AdminDialogs/GroupEditorDialog.test.ts

  Log Message:
  -----------
  NMS-20107: bring Manage Groups dialogs onto the current onms-ui seam

Drop the nested primevue IftaLabel from every field for FormField's own
label/for/required/error props, and replace the direct primevue Message error
banners with a themed role=alert element, so the dialogs no longer import any
un-wrapped PrimeVue primitive. Field errors now render through FormField (the
test selectors follow the FormField-generated error ids).


Compare: https://github.com/OpenNMS/opennms/compare/3d5c6cd42420...3626a369dfe5

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs