[OpenNMS/opennms] c350b9: NMS-20180: Address PR review: default-locale lower...

Scott Theleman via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20180-more-menu-issues/[email protected]>
  Branch: refs/heads/jira/NMS-20180-more-menu-issues
  Home:   https://github.com/OpenNMS/opennms
  Commit: c350b9d311b5cfeb74af97e3691c5cf6eacd9653
      https://github.com/OpenNMS/opennms/commit/c350b9d311b5cfeb74af97e3691c5cf6eacd9653
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-17 (Mon, 17 Aug 2026)

  Changed paths:
    M features/springframework-security/src/main/java/org/opennms/web/springframework/security/AuthorityPrincipal.java
    M features/springframework-security/src/main/java/org/opennms/web/springframework/security/LoginModuleUtils.java
    M features/springframework-security/src/main/java/org/opennms/web/springframework/security/OpenNMSAuthSuccessHandler.java
    M smoke-test/src/test/java/org/opennms/smoketest/WebappIT.java

  Log Message:
  -----------
  NMS-20180: Address PR review: default-locale lowercasing and test assertions

- Pass the raw servlet path to isInvalidSavedRequestUrl instead of
  pre-lowercasing with the default locale, which defeated the utility's
  Locale.ROOT handling under e.g. a Turkish locale
- Use Locale.ROOT for the admin-role comparisons in LoginModuleUtils and
  AuthorityPrincipal
- Assert the menu index.html auth redirect targets login.jsp
- Split the menu asset smoke test so a JS failure cannot hide the CSS result



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.