[OpenNMS/opennms] 23fdbc: NMS-19878: Address the Copilot review findings

Marshall Massengill via opennms-cvs <[email protected]> Wed, 19 Aug 2026 11:45:02 -0700

Newsgroups	gmane.network.opennms.cvs
Message-ID	<OpenNMS/opennms/push/refs/heads/mm/NMS-19878-smoke/[email protected]>

  Branch: refs/heads/mm/NMS-19878-smoke
  Home:   https://github.com/OpenNMS/opennms
  Commit: 23fdbc9e6a32ddb9c5a5db35f09d2fb9d73ab19f
      https://github.com/OpenNMS/opennms/commit/23fdbc9e6a32ddb9c5a5db35f09d2fb9d73ab19f
  Author: Marshall Massengill <[email protected]>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M ui/src/components/Topology/layout.ts
    M ui/src/components/Topology/sources.ts
    M ui/tests/components/Topology/layout.test.ts
    M ui/tests/components/Topology/sources.test.ts
    M ui/tests/containers/AppLayoutClasses.test.ts

  Log Message:
  -----------
  NMS-19878: Address the Copilot review findings

All three were real, though one was smaller than reported.

`buildSources` keyed its claimed-namespace set with a literal NUL byte. NUL is
the right separator semantically, since it cannot occur in a container id or a
namespace, but as a raw byte in source it is invisible and easy for tooling to
strip -- it rendered as a space in every reading of that file, including mine. It
is an explicit escape now, and a test constructs the collision the separator
prevents: a container id ending where a curated namespace begins keyed to the
same string and had its graphs silently dropped from the menu.

`computeEdgeCurvatures` tests every link against every node. Measured at the real
Layer 2 graph, 3454 nodes and 3501 links, that is 325ms -- noticeable but an
order of magnitude below the ForceAtlas2 layout it accompanies, and reached only
once the user has accepted the large-graph gate, so "freezing the page" overstates
it. Skipped past a ~2M node-link budget regardless: at that size links are
hairline and curving them buys no clarity.

The App layout test mounted without tearing down. Same leak that was fixed in the
container tests earlier in this branch, reintroduced in a new file: a live App
keeps its router watchers, so a later test's navigation drives a stale instance.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs