[OpenNMS/opennms] 09d2f4: NMS-20182: Drop the SPA footer's 1rem spacer div

  Branch: refs/heads/jira/NMS-20182-various-ui-fixes-smoke
  Home:   https://github.com/OpenNMS/opennms
  Commit: 09d2f49c7339545ad5d49c55493a9f8ffc6c3134
      https://github.com/OpenNMS/opennms/commit/09d2f49c7339545ad5d49c55493a9f8ffc6c3134
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M ui/src/components/Layout/Footer.vue

  Log Message:
  -----------
  NMS-20182: Drop the SPA footer's 1rem spacer div

The spacer sat inside the layout's footer row, making it 57px tall instead of
41px. A page whose content needs the full height left over from the header —
SNMP Config, OpenAPI and Resource Graphs all want exactly 868px at a 969px
viewport — therefore overflowed by the spacer's 16px and grew a scrollbar with
nothing to scroll to. Those three now fit exactly, and the footer looks the same
without it: it keeps its own 0.5rem padding and top border.


  Commit: 53173a597bcea5c418c0a04ac70330654e2d87b7
      https://github.com/OpenNMS/opennms/commit/53173a597bcea5c418c0a04ac70330654e2d87b7
  Author: Scott Theleman <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M ui/src/components/Logs/Editor.vue
    M ui/src/components/Logs/Logs.vue
    M ui/src/components/SCV/SCVForm.vue
    M ui/src/containers/Map.vue

  Log Message:
  -----------
  NMS-20182: Stop Map, Logs and SCV clipping the footer

Each of these pages sizes its tall element with a hand-picked `calc(100vh - x)`,
and each x was too small for the chrome actually above and below it, so the page
overflowed the viewport and pushed the footer off the bottom of the window — most
visibly on the map, where the footer was cut in half.

Derive the subtraction instead of guessing it: the masthead comes off via
--onms-header-height, then the 41px footer band, then whatever that page stacks
around the element — a breadcrumb row, card padding, a heading, a filter box.
Each site spells the terms out so the next person can check the arithmetic
against what they see. Map was 21px over, Logs 62px, SCV 7px; all three now fit
exactly, at a 969px viewport and at 720px.

The Logs page needed both halves of its card: capping only the editor left the
log list, with its heading and filter box, as the taller column.


Compare: https://github.com/OpenNMS/opennms/compare/92188f486702...53173a597bce

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs