[OpenNMS/opennms] e4e257: NMS-20100: Destination Paths tab

joseanesONMS via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20100/[email protected]> 
  Branch: refs/heads/jira/NMS-20100
  Home:   https://github.com/OpenNMS/opennms
  Commit: e4e25719e049b3b4c281604139093766e3433854
      https://github.com/OpenNMS/opennms/commit/e4e25719e049b3b4c281604139093766e3433854
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/config/GroupManager.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    A ui/src/components/AdminNotifications/DestinationPathEditorDialog.vue
    A ui/src/components/AdminNotifications/DestinationPathsTable.vue
    A ui/src/components/AdminNotifications/TargetRowEditor.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/stores/notificationConfigStore.ts
    M ui/src/types/notificationConfig.ts
    M ui/tests/stores/notificationConfigStore.test.ts

  Log Message:
  -----------
  NMS-20100: Destination Paths tab

The destination-path editor manages initial and escalation targets with interval controls, backed by new REST and store support. Fields use the FormField seam with inline info-icon help.


  Commit: cc77b9e880e39001c8e94ba4d4c4309283ce8782
      https://github.com/OpenNMS/opennms/commit/cc77b9e880e39001c8e94ba4d4c4309283ce8782
  Author: Jose Anes <[email protected]>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/TargetRowEditor.vue

  Log Message:
  -----------
  NMS-20119: use inputId so form controls associate with their labels

Rename the Notification Methods OnmsMultiSelect prop from labelId to inputId so its rendered input id matches the FormField for attribute and the label association is real.


  Commit: f901d0300574bca245009bd87c5994aa845a8df0
      https://github.com/OpenNMS/opennms/commit/f901d0300574bca245009bd87c5994aa845a8df0
  Author: Jose Anes <[email protected]>
  Date:   2026-08-12 (Wed, 12 Aug 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/config/DestinationPathManager.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    M ui/src/services/notificationConfigService.ts

  Log Message:
  -----------
  NMS-20119: fix destination-path reload, last-path delete, and rename consistency

Make a reload replace the destination-path map instead of merging over it by
building a new TreeMap and swapping the field reference in one assignment (and
mark parseXML synchronized), so readers keep a consistent snapshot and
saveCurrent()'s iteration is never emptied mid-flight. Reject deleting the last
remaining path with a 400 (it would otherwise 500 on schema validation) and
surface the server's message in the delete UI. On a rename, roll back the
persisted path change if the follow-up notifications save fails so
destinationPaths.xml and notifications.xml cannot diverge. Adds IT coverage for
the last-path rejection.


  Commit: 56c5ea81afc6a3021174919b60fac296e75bf712
      https://github.com/OpenNMS/opennms/commit/56c5ea81afc6a3021174919b60fac296e75bf712
  Author: Jose Anes <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    R opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    A opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java
    R opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    A opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/NotificationConfigRestServiceIT.java
    M ui/src/services/notificationConfigService.ts
    M ui/src/types/notificationConfig.ts

  Log Message:
  -----------
  NMS-20119: move the notification-config REST service to v2 as clean JSON

Relocate NotificationConfigRestService (and its IT) from rest.v1 to rest.v2 so
it is served under /api/v2/notification-config. Decouple it from the v1
OnmsRestService base: the read/write/update lock and the getException helpers it
used now live on the service itself. Drop the m_ prefix and the JAXB annotations
from the NotificationStatus DTO (plain camelCase-JSON POJO; wire name unchanged).
The UI service now calls the v2 axios instance.


  Commit: a85b4fd84623fdb3a6e9a2248673a469dad5fb2a
      https://github.com/OpenNMS/opennms/commit/a85b4fd84623fdb3a6e9a2248673a469dad5fb2a
  Author: Jose Anes <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java

  Log Message:
  -----------
  NMS-20119: drop m_ prefixes and the local isBlank helper

Address review (same as #8710): remove the m_ prefix from the service fields
(eventProxy and the lock fields), drop the now-redundant @Qualifier, and use
org.apache.commons.lang.StringUtils.isBlank instead of the hand-rolled helper.


  Commit: 04ce7b431141c69896d09a18e52559ad9563562d
      https://github.com/OpenNMS/opennms/commit/04ce7b431141c69896d09a18e52559ad9563562d
  Author: Jose Anes <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/config/DestinationPathManager.java
    M opennms-config/src/main/java/org/opennms/netmgt/config/GroupManager.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/NotificationConfigRestServiceIT.java
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    A ui/src/components/AdminNotifications/DestinationPathEditorDialog.vue
    A ui/src/components/AdminNotifications/DestinationPathsTable.vue
    A ui/src/components/AdminNotifications/TargetRowEditor.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/stores/notificationConfigStore.ts
    M ui/src/types/notificationConfig.ts
    M ui/tests/stores/notificationConfigStore.test.ts

  Log Message:
  -----------
  Merge #8711 (NMS-20119 Destination Paths) into epic

# Conflicts:
#	opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java
#	opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/NotificationConfigRestServiceIT.java
#	ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
#	ui/src/services/index.ts
#	ui/src/services/notificationConfigService.ts
#	ui/src/stores/notificationConfigStore.ts
#	ui/src/types/notificationConfig.ts
#	ui/tests/stores/notificationConfigStore.test.ts


Compare: https://github.com/OpenNMS/opennms/compare/78f863e812a7...04ce7b431141

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.