[OpenNMS/opennms] bbbe66: NMS-20120: Path Outages tab

joseanesONMS via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20100/[email protected]>
  Branch: refs/heads/jira/NMS-20100
  Home:   https://github.com/OpenNMS/opennms
  Commit: bbbe66c9f0016828ea225f2ef3038bd2aa5ec69b
      https://github.com/OpenNMS/opennms/commit/bbbe66c9f0016828ea225f2ef3038bd2aa5ec69b
  Author: Jose Anes <[email protected]>
  Date:   2026-08-13 (Thu, 13 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    A ui/src/components/AdminNotifications/PathOutagesTab.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/stores/notificationConfigStore.ts
    M ui/src/types/notificationConfig.ts
    M ui/tests/stores/notificationConfigStore.test.ts

  Log Message:
  -----------
  NMS-20120: Path Outages tab

Add the Path Outages configuration tab: a critical-path editor with a
filter-rule preview and an apply/clear flow (a blank IP clears the path for
matching nodes), backed by REST over PathOutageDao/NodeDao in Hibernate
transactions rather than raw JDBC. Reject a rule that matches no nodes and a
non-ICMP service with 400s, return 404 when deleting a critical path that isn't
configured, map filter-evaluation infrastructure failures to 500 rather than a
raw stack, and drop the redundant rule evaluation per apply. The clear
confirmation no longer shows a preview-capped node count, IPv4-mapped IPv6
addresses validate correctly, and IT coverage exercises the new cases. Fields
use the FormField seam with inline info-icon help.


  Commit: 5a5e237d98dea25c57de01345ac725cce79d6172
      https://github.com/OpenNMS/opennms/commit/5a5e237d98dea25c57de01345ac725cce79d6172
  Author: Jose Anes <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    R opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    A opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java
    R opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    A opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/NotificationConfigRestServiceIT.java
    M ui/src/services/notificationConfigService.ts
    M ui/src/types/notificationConfig.ts

  Log Message:
  -----------
  NMS-20120: move the notification-config REST service to v2 as clean JSON

Relocate NotificationConfigRestService (and its IT) from rest.v1 to rest.v2 so
it is served under /api/v2/notification-config. Decouple it from the v1
OnmsRestService base: the read/write/update lock and the getException helpers it
used now live on the service itself. Drop the m_ prefixes and JAXB annotations
from the DTOs (NotificationStatus and the PathOutage DTOs) so they are plain
camelCase-JSON POJOs; wire names are unchanged. The UI service now calls the v2
axios instance.


  Commit: f0096727f855c29ce0e0a3f4e4cddebe9b6a7052
      https://github.com/OpenNMS/opennms/commit/f0096727f855c29ce0e0a3f4e4cddebe9b6a7052
  Author: Jose Anes <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java

  Log Message:
  -----------
  NMS-20120: drop m_ prefixes and use StringUtils.isBlank

Address review (same as #8710): remove the m_ prefix from all service fields
(eventProxy, the lock fields, and the path-outage DAOs), drop the now-redundant
@Qualifier, and use org.apache.commons.lang.StringUtils.isBlank for the
null-or-blank checks.


  Commit: 37d2f42b9a961138a610775d47b9432836e27d17
      https://github.com/OpenNMS/opennms/commit/37d2f42b9a961138a610775d47b9432836e27d17
  Author: Jose Anes <[email protected]>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/NotificationConfigRestServiceIT.java
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    A ui/src/components/AdminNotifications/PathOutagesTab.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/stores/notificationConfigStore.ts
    M ui/src/types/notificationConfig.ts
    M ui/tests/stores/notificationConfigStore.test.ts

  Log Message:
  -----------
  Merge #8712 (NMS-20120 Path Outages) into epic

# Conflicts:
#	opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationConfigRestService.java
#	opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/NotificationConfigRestServiceIT.java
#	ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
#	ui/src/services/index.ts
#	ui/src/services/notificationConfigService.ts
#	ui/src/stores/notificationConfigStore.ts
#	ui/src/types/notificationConfig.ts
#	ui/tests/stores/notificationConfigStore.test.ts


Compare: https://github.com/OpenNMS/opennms/compare/04ce7b431141...37d2f42b9a96

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.