[OpenNMS/opennms] fb0600: NMS-20107: persist category authorizations on rena...
joseanesONMS via opennms-cvs <[email protected]>
| Newsgroups | gmane.network.opennms.cvs |
|---|---|
| Message-ID | <OpenNMS/opennms/push/refs/heads/jira/NMS-20107-manage-groups-primevue/[email protected]> |
Branch: refs/heads/jira/NMS-20107-manage-groups-primevue
Home: https://github.com/OpenNMS/opennms
Commit: fb0600a758e5c1088bb2221815e916e2af69d5a4
https://github.com/OpenNMS/opennms/commit/fb0600a758e5c1088bb2221815e916e2af69d5a4
Author: Jose Anes <[email protected]>
Date: 2026-08-21 (Fri, 21 Aug 2026)
Changed paths:
M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/GroupsRestService.java
M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/GroupsRestServiceIT.java
M ui/src/lib/adminValidation.ts
M ui/src/services/groupAdminService.ts
M ui/tests/lib/adminValidation.test.ts
A ui/tests/services/groupAdminService.test.ts
Log Message:
-----------
NMS-20107: persist category authorizations on rename/delete; fix member picker
Address the review blockers on the Manage Groups API:
- Category authorizations never reached the DB. GroupService.renameGroup and
deleteGroup mutate managed OnmsCategory entities without an explicit save,
and OSIV runs with MANUAL flush, so the changes were silently discarded:
delete left orphaned authorized_group rows and rename dropped the group's
categories. Annotate both REST methods @Transactional so the OSIV session
flushes on commit, matching the legacy @Transactional WebGroupRepository
path. GroupsRestServiceIT now asserts migration on rename and clearing on
delete.
- The member picker was always empty. getGroupMemberCandidates read
resp.data.users, but v1 /rest/users serializes the list under "user"
(@JsonProperty). Read the correct key and cover it with a service test.
Also make the feature's UI files pass pnpm lint.
To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list
To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs