[OpenNMS/opennms] 6e7d15: NMS-20108: locale-proof schedule parsing; guard me...

  Branch: refs/heads/jira/NMS-20108-oncall-roles-pr
  Home:   https://github.com/OpenNMS/opennms
  Commit: 6e7d1529552b5eca64cd043acdd8be5274774b21
      https://github.com/OpenNMS/opennms/commit/6e7d1529552b5eca64cd043acdd8be5274774b21
  Author: Jose Anes <[email protected]>
  Date:   2026-08-21 (Fri, 21 Aug 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/config/BasicScheduleUtils.java
    M opennms-config/src/test/java/org/opennms/netmgt/config/BasicScheduleUtilsTest.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/OnCallRolesRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/OnCallRolesRestServiceIT.java
    M ui/src/components/ManageOnCallRoles/RoleCalendarDialog.vue
    M ui/src/components/ManageOnCallRoles/RoleEditorDialog.vue
    M ui/src/components/ManageOnCallRoles/RoleRenameDialog.vue
    M ui/src/lib/adminValidation.ts
    M ui/tests/lib/adminValidation.test.ts

  Log Message:
  -----------
  NMS-20108: locale-proof schedule parsing; guard membership-group changes

Address the review blockers on On-Call Roles:

- "Specific" one-off schedules were dropped on servers whose default locale
  abbreviates months differently from Locale.ROOT (the locale WebSchedEntry
  writes with). BasicScheduleUtils.setOutCalTime parsed with the JVM default
  locale, so a round-trip through it failed on e.g. a German or Japanese
  server and silently discarded the entry. Parse with Locale.ROOT to match
  the writer; a locale-pinned unit test covers it.
- Changing a role's membership group orphaned its schedules. validateDtoFields
  only checked schedule users against the group when the request carried
  schedules, but the editor changes the group without resubmitting them, so
  retained schedules kept paging users no longer in the group. Re-validate the
  retained schedules against the new group (and drop the "already on the role"
  exemption when the group changes), rejecting the change with a clear message.
  Covered by a new IT.

Also bring the On-Call Roles dialogs onto the current @opennms/onms-ui seam:
drop primevue IftaLabel for FormField's label/for, replace the primevue
Message banners with a themed role=alert element, and bind OnmsSelect via its
inputId prop. No page imports an un-wrapped PrimeVue primitive; pnpm lint clean.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs