[OpenNMS/opennms] 45aa44: NMS-20263: Correct inaccurate annotations found in...

  Branch: refs/heads/mm/NMS-20263-smoke
  Home:   https://github.com/OpenNMS/opennms
  Commit: 45aa44c0c17e68c2432fdf3eeb949d1f4e9f7197
      https://github.com/OpenNMS/opennms/commit/45aa44c0c17e68c2432fdf3eeb949d1f4e9f7197
  Author: Marshall Massengill <[email protected]>
  Date:   2026-08-31 (Mon, 31 Aug 2026)

  Changed paths:
    M features/measurements/api/pom.xml
    M features/measurements/api/src/main/java/org/opennms/netmgt/measurements/model/Expression.java
    M features/measurements/api/src/main/java/org/opennms/netmgt/measurements/model/FilterParamDef.java
    M features/measurements/api/src/main/java/org/opennms/netmgt/measurements/model/QueryResponse.java
    M features/measurements/rest/src/main/java/org/opennms/web/rest/v1/MeasurementsRestService.java
    M features/status/rest/src/main/java/org/opennms/web/rest/v2/status/StatusRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/AcknowledgmentRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/AlarmRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/AvailabilityRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/CategoryRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/EventRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/FilesystemRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/GraphRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/GroupRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/HeatMapRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/IfServicesRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/KscRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/LogRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/MinionRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NodeRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/OnmsIpInterfaceResource.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/OnmsSnmpInterfaceResource.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/OutageRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/RequisitionRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/ScheduledOutagesRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/TimelineRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/UserRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/WebAssetsRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/config/DataCollectionConfigResource.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/config/JavamailConfigurationResource.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/config/SnmpConfigurationResource.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/config/TicketerConfig.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/config/TrapdConfigurationResource.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/AlarmRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DiscoveryRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/EventRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/IpInterfaceRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/MinionRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/MonitoringLocationRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NodeCategoriesRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NodeMonitoredServiceRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/NotificationRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/OutageRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/ProvisiondStatusRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SnmpInterfaceRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/TopologyViewDTO.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/UserDefinedLinkRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/api/DataCollectionConfRestApi.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/api/EventConfRestApi.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/api/NodeLinkRestApi.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/model/AlarmPropertyUpdateRequest.java

  Log Message:
  -----------
  NMS-20263: Correct inaccurate annotations found in an adversarial review

Every operation's documented status codes, error bodies and examples were
re-verified against the handlers, the shared helpers and the DAOs, with
read-only live probes where the code path was ambiguous. Fixes the claims
that did not survive:

- v1 error bodies: ~75 4xx/5xx responses across seven services declared
  application/json where OnmsRestService's helpers emit text/plain
- v2 Minion and MonitoringLocation JSON/XML PUT: an unknown id is not a
  404, saveOrUpdate inserts a new row and answers 204
- unknown query parameters in v1 node/interface/ifservices resources fail
  with 500 'Unknown entity: null' rather than being ignored; the v1
  minions filter 400 is likewise really a 500
- situations: unknown alarm ids fail with 500 rather than being dropped,
  the _s behaviour claim was wrong in both directions, the 403 examples
  now quote SecurityHelper's real messages, and the update/memo/journal/
  ticket operations document their reachable 403
- unreachable responses corrected: v1 whoami 204 (really 404), category
  availability 404 (rewrapped as 500), eventconf delete 400 (mapped to
  500), web-assets fallback 404 (broken list mutation, 500)
- wrong facts: KSC timespan list missing twelve valid values, the three
  datacollection child filters fall back to sorting by name rather than
  createdTime, wrong schema classes on the v1 trapd and datacollection
  config resources, kebab-case JSON keys on the snmp config resource,
  a malformed JSON example in GraphRestService, totalCount:null examples
  contradicted by JaxbListWrapper's count fallback, and ten
  datacollection operations missing their real 500 response
- the v1 trapd operationId no longer collides with the v2 one

The Jackson 2 @JsonProperty annotations added to the measurements model
for the OpenAPI generator are now named explicitly so a Jackson 2
consumer would serialize the real wire name 'value', and the new
com.fasterxml.jackson.annotation import on that bundle is optional, in
line with the swagger imports. Also drops two unused imports and an
unrelated license-header reflow.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs