[OpenNMS/opennms] 39a756: NMS-20106: validate tuiPin, roll back failed saves...

  Branch: refs/heads/jira/NMS-20106-manage-users-primevue
  Home:   https://github.com/OpenNMS/opennms
  Commit: 39a756ddf7a1e3bae0d0c775eb956d84a7e95c6b
      https://github.com/OpenNMS/opennms/commit/39a756ddf7a1e3bae0d0c775eb956d84a7e95c6b
  Author: Jose Anes <[email protected]>
  Date:   2026-08-31 (Mon, 31 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/UsersRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/UsersRestServiceIT.java
    M ui/src/components/ManageUsers/DutyScheduleEditor.vue
    M ui/tests/components/ManageUsers/DutyScheduleEditor.test.ts

  Log Message:
  -----------
  NMS-20106: validate tuiPin, roll back failed saves, stop dialog rewrites !smoke

users.xsd constrains tui-pin to [0-9]+ but it was the only field written
unvalidated: a bad PIN entered the in-memory map, failed the schema-validating
marshal, and — with isUpdateNeeded() seeing an unchanged file — wedged every
later user mutation until restart. It is now rejected with a 400 before it
touches the map, and the IT proves a valid write still succeeds after the
rejected one.

updateUser and setPassword get the same rollback discipline createUser
already had: a failed save re-saves the previous state, so a 500 no longer
leaves a new password hash live in memory until a restart quietly reverts it.

The duty-schedule editor no longer rewrites schedules on open: parsed rows
keep their incoming string and serialize it byte-identically until the row
itself is edited, and the watcher only emits when the value actually changes.
The server grandfathers legacy strings byte-identically, so the old
mount-time canonicalization (day order, zero-padding) made such users
unsavable for unrelated edits. Tests cover the non-canonical shape from the
review: no emit on mount, untouched rows survive verbatim, canonicalization
only on a real edit.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs