[OpenNMS/opennms] 9b7432: NMS-20283: Count notifications, not deliveries, in...
OpenNMS Machine User via opennms-cvs <[email protected]>
| Newsgroups | gmane.network.opennms.cvs |
|---|---|
| Message-ID | <OpenNMS/opennms/push/refs/heads/foundation-2025/[email protected]> |
Branch: refs/heads/foundation-2025
Home: https://github.com/OpenNMS/opennms
Commit: 9b7432c5311f09a7af0de97f5ddb6e0d8c7f397e
https://github.com/OpenNMS/opennms/commit/9b7432c5311f09a7af0de97f5ddb6e0d8c7f397e
Author: Marshall Massengill <[email protected]>
Date: 2026-09-02 (Wed, 02 Sep 2026)
Changed paths:
M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationRestService.java
M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationRestServiceIT.java
Log Message:
-----------
NMS-20283: Count notifications, not deliveries, in the notification summary (#8834)
/notifications/summary derived userUnacknowledgedCount, teamUnacknowledgedCount
and the newest-notifications list from a criteria join to usersNotified, and
countMatching counts join rows. A notification carries one usersNotified row per
notification method, so a user notified by both email and pager was counted
twice and appeared twice in the list. On a real install the personal count came
back larger than the total unacknowledged count, and the header badge disagreed
with the notification list it links to.
Marking the three criteria distinct() moves the join into a subquery on the
notification id, so both the counts and the list are per notification.
This changes a published REST field: installs whose users have several
notification methods configured will see these counts drop to the real number
of notifications.
Commit: 1bef94ff6e387dcf999ea308b68a80909bb1e351
https://github.com/OpenNMS/opennms/commit/1bef94ff6e387dcf999ea308b68a80909bb1e351
Author: CI/CD System <[email protected]>
Date: 2026-09-02 (Wed, 02 Sep 2026)
Changed paths:
M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationRestService.java
M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationRestServiceIT.java
Log Message:
-----------
Merge remote-tracking branch 'origin/foundation-2024' into foundation-2025
Compare: https://github.com/OpenNMS/opennms/compare/d2a8516e29cb...1bef94ff6e38
To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list
To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs