[OpenNMS/opennms] d58d90: NMS-19948: unmount tab-container test wrappers to ...

Scott Theleman via opennms-cvs <[email protected]> Tue, 14 Jul 2026 08:44:06 -0700

Newsgroups	gmane.network.opennms.cvs
Message-ID	<OpenNMS/opennms/push/refs/heads/jira/NMS-19976-primevue-migration-menubar/[email protected]>

  Branch: refs/heads/jira/NMS-19976-primevue-migration-menubar
  Home:   https://github.com/OpenNMS/opennms
  Commit: d58d90e587c616a6662df229dc8c2e40f4ed045a
      https://github.com/OpenNMS/opennms/commit/d58d90e587c616a6662df229dc8c2e40f4ed045a
  Author: Scott Theleman <[email protected]>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M ui/tests/components/Nodes/InterfacesTabs.test.ts
    M ui/tests/containers/SnmpDataCollection.test.ts
    M ui/tests/containers/TrapdConfiguration.test.ts

  Log Message:
  -----------
  NMS-19948: unmount tab-container test wrappers to fix flaky HTMLElement error

PrimeVue TabList schedules setTimeout(updateInkBar, 150) in mounted() and
never clears it in beforeUnmount(). When a test mounts a Tabs-rendering
component without unmounting, that orphaned timer outlives the test file and
fires against the torn-down happy-dom environment, throwing 'HTMLElement is
not defined' (flaky on CI, timing-dependent). Unmounting in afterEach clears
the component's template refs so updateInkBar hits its early-return guard
before touching any DOM helper.

Fixes the observed failure in SnmpDataCollection.test.ts and the same latent
flake in TrapdConfiguration.test.ts and InterfacesTabs.test.ts.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs