[OpenNMS/opennms] 5cb9db: NMS-20004: tolerate unrepresentable ipaddr values ...

  Branch: refs/heads/release-36.x
  Home:   https://github.com/OpenNMS/opennms
  Commit: 5cb9db511451d26fa102de6f54aa1cdca3e3c0e7
      https://github.com/OpenNMS/opennms/commit/5cb9db511451d26fa102de6f54aa1cdca3e3c0e7
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/filter/JdbcFilterDao.java
    A opennms-config/src/test/java/org/opennms/netmgt/filter/JdbcFilterDaoToInetAddressTest.java

  Log Message:
  -----------
  NMS-20004: tolerate unrepresentable ipaddr values in filter results

A single ipinterface row whose ipaddr value cannot be converted to an
InetAddress aborted the whole filter evaluation with an opaque
UndeclaredThrowableException (null message): the result-row conversion
in JdbcFilterDao used InetAddress.getByName(), which throws for IPv6
zone ids naming an interface that does not resolve on this host, does
a DNS lookup per row for hostname-like values, and silently turns an
empty string into the loopback address. The default rule *.*.*.*
matches every interface, so one bad row could break every package
filter evaluation for pollerd, collectd, threshd, and notifd.

Convert result rows tolerantly instead: accept only IP literals (no
DNS resolution; numeric zone ids convert exactly as before), fall back
to the zone-stripped address for interface-name zones, and log-and-skip
anything that still cannot be represented rather than failing the
evaluation.


  Commit: 74a821c45e091cb5cbf9bbfb2c081d5e8f9265f5
      https://github.com/OpenNMS/opennms/commit/74a821c45e091cb5cbf9bbfb2c081d5e8f9265f5
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/filter/JdbcFilterDao.java
    M opennms-config/src/test/java/org/opennms/netmgt/filter/JdbcFilterDaoToInetAddressTest.java

  Log Message:
  -----------
  NMS-20004: never resolve zone ids locally; reject zone suffixes on IPv4

Interface-name zones now always fall back to the zone-stripped address
instead of first attempting resolution against this host's interfaces,
which made results depend on the evaluating host's interface names.
Zone suffixes on IPv4 literals (never valid) are skipped outright
rather than reaching InetAddress.getByName with an unparseable value.


  Commit: 3a1519249350fc638a4e1e921b4f0c9fe339bbc4
      https://github.com/OpenNMS/opennms/commit/3a1519249350fc638a4e1e921b4f0c9fe339bbc4
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/filter/JdbcFilterDao.java

  Log Message:
  -----------
  NMS-20004: use Guava InetAddresses for literal validation in filter results

Review feedback: replace the hand-rolled IPv4/IPv6 literal regexes with
InetAddresses.isInetAddress, which never resolves hostnames and validates
more precisely. It must run on the zone-stripped address part because
Guava 31.1 rejects scoped addresses; the zone handling is unchanged.


  Commit: 21f35cec1f1f3cc6b3b76bfe95d68926b58dd4d1
      https://github.com/OpenNMS/opennms/commit/21f35cec1f1f3cc6b3b76bfe95d68926b58dd4d1
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/filter/JdbcFilterDao.java
    A opennms-config/src/test/java/org/opennms/netmgt/filter/JdbcFilterDaoToInetAddressTest.java

  Log Message:
  -----------
  Merge pull request #8627 from OpenNMS/NMS-20004-IPv6ZoneIDFix-smoke

NMS-20004: tolerate unrepresentable ipaddr values in filter results


  Commit: 898b560ebbb1460d7389babe21dd6905f78aec2f
      https://github.com/OpenNMS/opennms/commit/898b560ebbb1460d7389babe21dd6905f78aec2f
  Author: CI/CD System <[email protected]>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/filter/JdbcFilterDao.java
    A opennms-config/src/test/java/org/opennms/netmgt/filter/JdbcFilterDaoToInetAddressTest.java

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/foundation-2024' into foundation-2025


  Commit: 0e4003c92b1d02974281a5fdba893d9ba769c4fd
      https://github.com/OpenNMS/opennms/commit/0e4003c92b1d02974281a5fdba893d9ba769c4fd
  Author: CI/CD System <[email protected]>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M opennms-config/src/main/java/org/opennms/netmgt/filter/JdbcFilterDao.java
    A opennms-config/src/test/java/org/opennms/netmgt/filter/JdbcFilterDaoToInetAddressTest.java

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/foundation-2025' into release-36.x


Compare: https://github.com/OpenNMS/opennms/compare/14fe0f2bc9a1...0e4003c92b1d

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs