[OpenNMS/opennms] 93a247: NMS-20008: Honor thresholding-enabled parameter in...

  Branch: refs/heads/foundation-2024
  Home:   https://github.com/OpenNMS/opennms
  Commit: 93a247e775db32109fdb69979cf5cceaf20e89ff
      https://github.com/OpenNMS/opennms/commit/93a247e775db32109fdb69979cf5cceaf20e89ff
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M opennms-services/src/main/java/org/opennms/netmgt/collectd/CollectableService.java

  Log Message:
  -----------
  NMS-20008: Honor thresholding-enabled parameter in collectd

The thresholding-enabled service parameter was only honored by the poller
(LatencyStoringServiceMonitorAdaptor); collectd created a thresholding
session and ran threshold processing on every collection regardless of the
parameter, so setting thresholding-enabled=false in
collectd-configuration.xml silently did nothing (SUPPORT-3261).

CollectableService now skips thresholding session creation when the
parameter is explicitly set to false. Default remains enabled, preserving
existing behavior for configurations that do not set the parameter.


  Commit: f7c5ca73434b1768d57ae0d4ed979fb96e81b2f0
      https://github.com/OpenNMS/opennms/commit/f7c5ca73434b1768d57ae0d4ed979fb96e81b2f0
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M opennms-services/src/main/java/org/opennms/netmgt/collectd/CollectableService.java
    M opennms-services/src/test/java/org/opennms/netmgt/collectd/CollectableServiceTest.java

  Log Message:
  -----------
  NMS-20008: Add tests for thresholding-enabled handling, clarify default comment

Addresses Copilot review feedback: the comment now states that the poller's
default for the same parameter is false while collectd defaults to enabled,
and CollectableServiceTest verifies the thresholding session is not created
when thresholding-enabled=false and is created when the parameter is absent
or true.


  Commit: 02936fa106accdb313266660f7b465fc14b91a17
      https://github.com/OpenNMS/opennms/commit/02936fa106accdb313266660f7b465fc14b91a17
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M opennms-services/src/main/java/org/opennms/netmgt/collectd/CollectableService.java
    M opennms-services/src/test/java/org/opennms/netmgt/collectd/CollectableServiceTest.java

  Log Message:
  -----------
  Merge pull request #8632 from OpenNMS/mm/NMS-20008-smoke

NMS-20008: thresholding-enabled parameter is ignored by collectd


Compare: https://github.com/OpenNMS/opennms/compare/21f35cec1f1f...02936fa106ac

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs