[OpenNMS/opennms] e978b7: NMS-20009: Build poller metadata scope once per re...

OpenNMS Machine User via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/merge-foundation/foundation-2024-to-foundation-2025/[email protected]>
  Branch: refs/heads/merge-foundation/foundation-2024-to-foundation-2025
  Home:   https://github.com/OpenNMS/opennms
  Commit: e978b72035943c63d1d18fdc25b6e2a6909a3ef0
      https://github.com/OpenNMS/opennms/commit/e978b72035943c63d1d18fdc25b6e2a6909a3ef0
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M features/poller/client-rpc/src/main/java/org/opennms/netmgt/poller/client/rpc/PollerRequestBuilderImpl.java

  Log Message:
  -----------
  NMS-20009: Build poller metadata scope once per request instead of twice

execute() built the node/interface/service scope twice per poll - once for
the configured attributes and once for the monitor's runtime attributes -
at three read-only database transactions per build (SUPPORT-3261).
Memoize it on the request builder.


  Commit: 0acd5f77d19f69515f23f8eb503ac2cf8c64222c
      https://github.com/OpenNMS/opennms/commit/0acd5f77d19f69515f23f8eb503ac2cf8c64222c
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M features/poller/client-rpc/src/main/java/org/opennms/netmgt/poller/client/rpc/PollerRequestBuilderImpl.java

  Log Message:
  -----------
  NMS-20009: Invalidate the memoized scope when its inputs change

Addresses Copilot review feedback: withService and withPatternVariables now
reset the cached scope, so a builder mutated after a getScope() call sees
fresh values, matching pre-memoization semantics. execute() still builds the
scope only once since nothing mutates between its two uses.


  Commit: 9ce795e2e8f1f2e4f872cde8c95597aa80e69eae
      https://github.com/OpenNMS/opennms/commit/9ce795e2e8f1f2e4f872cde8c95597aa80e69eae
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-17 (Fri, 17 Jul 2026)

  Changed paths:
    M features/poller/client-rpc/src/main/java/org/opennms/netmgt/poller/client/rpc/PollerRequestBuilderImpl.java

  Log Message:
  -----------
  Merge pull request #8633 from OpenNMS/mm/NMS-20009-smoke

NMS-20009: Poller builds the metadata scope twice per poll


  Commit: da5dee55992b696d75cdcbfc839bba111490b4d1
      https://github.com/OpenNMS/opennms/commit/da5dee55992b696d75cdcbfc839bba111490b4d1
  Author: CI/CD System <[email protected]>
  Date:   2026-07-17 (Fri, 17 Jul 2026)

  Changed paths:
    M features/poller/client-rpc/src/main/java/org/opennms/netmgt/poller/client/rpc/PollerRequestBuilderImpl.java

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/foundation-2024' into foundation-2025


Compare: https://github.com/OpenNMS/opennms/compare/58fe97cbc303...da5dee55992b

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.