[OpenNMS/opennms] 96598d: NMS-20045: address review feedback

  Branch: refs/heads/mm/NMS-20045-smoke
  Home:   https://github.com/OpenNMS/opennms
  Commit: 96598d0a26856b85ea1228008e6da75a08441c3c
      https://github.com/OpenNMS/opennms/commit/96598d0a26856b85ea1228008e6da75a08441c3c
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-20 (Mon, 20 Jul 2026)

  Changed paths:
    M features/surveillance-views/src/main/java/org/opennms/netmgt/surveillance/views/impl/DefaultSurveillanceViewDataService.java
    M features/surveillance-views/src/main/resources/META-INF/opennms/component-dao.xml
    M features/surveillance-views/src/test/java/org/opennms/netmgt/surveillance/views/DefaultSurveillanceViewDataServiceRtcIT.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SurveillanceViewRestService.java

  Log Message:
  -----------
  NMS-20045: address review feedback

- Fix the stale component-dao.xml comment: init() seeds the stock default
  view; it no longer claims to import the legacy XML.
- Remove the unused logger from SurveillanceViewRestService.
- Rewrite the RTC test's 'now - -1h' double negative as an explicit
  addition and document the period-boundary scenario it sets up.
- Add whitespace between the two category subqueries in the intersection
  SQL. Cosmetic only: '))and' is valid SQL (the ITs execute it against
  real Postgres) and matches the retired Vaadin implementationverbatim,
  but the spaced form reads better.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs