[OpenNMS/opennms] 552993: NMS-19981: Add Apache-2.0 attribution for vendored...

Scott Theleman via opennms-cvs <[email protected]>
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-19981-primevue-migration-feather-icon-and-cleanup/[email protected]>
  Branch: refs/heads/jira/NMS-19981-primevue-migration-feather-icon-and-cleanup
  Home:   https://github.com/OpenNMS/opennms
  Commit: 55299300dcfe89497eeefac8252a0852e5ee704b
      https://github.com/OpenNMS/opennms/commit/55299300dcfe89497eeefac8252a0852e5ee704b
  Author: Scott Theleman <[email protected]>
  Date:   2026-07-21 (Tue, 21 Jul 2026)

  Changed paths:
    M ui/README.md
    A ui/THIRD-PARTY-LICENSE.md
    M ui/src/composables/useOutsideClick.ts

  Log Message:
  -----------
  NMS-19981: Add Apache-2.0 attribution for vendored FeatherDS code

Add ui/THIRD-PARTY-LICENSE.md documenting the FeatherDS (@featherds/*
0.12.x, (C) NantHealth, Apache-2.0) code vendored during the de-Feather
work: the 262 icon SFCs plus the derived composable, styles, types, and
layout files, marked verbatim vs modified, with the full Apache-2.0 text
(satisfies Apache-2.0 section 4). Reference it from ui/README.md and add a
source-level attribution note to useOutsideClick.ts reconciling the AGPLv3
header with the upstream Apache-2.0 grant.


  Commit: 31542c429d268deabcff642f4c9fb42302665288
      https://github.com/OpenNMS/opennms/commit/31542c429d268deabcff642f4c9fb42302665288
  Author: Scott Theleman <[email protected]>
  Date:   2026-07-21 (Tue, 21 Jul 2026)

  Changed paths:
    M ui/src/components/Map/LeafletMap.vue

  Log Message:
  -----------
  NMS-19981: Restore Leaflet keyboard nav (WCAG 2.1.1); handle focus-scroll via CSS

Re-enable Leaflet keyboard support on the map (arrow-key pan / +- zoom) that
was previously disabled to stop a click-focus scroll shift under the fixed
menu bar; removing it failed WCAG 2.1.1. Instead reserve the menu-bar height
with scroll-margin-top on the .leaflet-container so the focus-triggered
scroll-into-view stops below the bar rather than sliding the map under it.


  Commit: 794511b29e7e89f0b62160a77bc1405f1aae1623
      https://github.com/OpenNMS/opennms/commit/794511b29e7e89f0b62160a77bc1405f1aae1623
  Author: Scott Theleman <[email protected]>
  Date:   2026-07-21 (Tue, 21 Jul 2026)

  Changed paths:
    M ui/src/components/Map/LeafletMap.vue
    M ui/src/components/Map/utils.ts

  Log Message:
  -----------
  NMS-19981: Open map popups below the marker; stop autoPan map-jump

Marker and cluster popups previously opened above the marker with autoPan on,
so clicking a marker in the upper part of the map (under the fixed menu bar)
panned the whole map down to fit the popup. Turn autoPan off and, in a
popupopen handler, offset each popup below its marker by the popup's own
measured height (Leaflet has no popup direction option). Hide the now-pointless
tip via .onms-popup-below. Bottom-edge markers, where a below-popup would run
past the map's lower edge, get a one-directional pan-up nudge to reveal it;
top markers never shift.

Also close the open popup on Esc regardless of focus: Leaflet's own Esc-to-close
only fires while the map container is focused, so tabbing into the popup's links
blurred it and broke Esc. A document keydown listener, attached only while a
popup is open and running in the bubble phase, closes the popup without
competing with the menu search's Esc handler (which stops propagation first).


Compare: https://github.com/OpenNMS/opennms/compare/2cb12f8077e8...794511b29e7e

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.