[OpenNMS/opennms] 06b84f: NMS-19981: Keep legacy JSP text/link colors readab...

Scott Theleman via opennms-cvs <[email protected]> Tue, 21 Jul 2026 12:45:55 -0700

Newsgroups	gmane.network.opennms.cvs
Message-ID	<OpenNMS/opennms/push/refs/heads/jira/NMS-19981-primevue-migration-feather-icon-and-cleanup/[email protected]>

  Branch: refs/heads/jira/NMS-19981-primevue-migration-feather-icon-and-cleanup
  Home:   https://github.com/OpenNMS/opennms
  Commit: 06b84f86733a5a7efe5c33b68d5e960792c040e4
      https://github.com/OpenNMS/opennms/commit/06b84f86733a5a7efe5c33b68d5e960792c040e4
  Author: Scott Theleman <[email protected]>
  Date:   2026-07-21 (Tue, 21 Jul 2026)

  Changed paths:
    M ui/src/styles/opennms-styles.scss

  Log Message:
  -----------
  NMS-19981: Keep legacy JSP text/link colors readable in dark mode

The standalone menu bundle applies the .open-light/.open-dark theme class to
<html>/<body> of legacy JSP pages, but those pages are not dark-theme aware
(their background stays light). In dark mode the themed tokens then flipped to
their on-dark values, making legacy content unreadable: links
(--onms-clickable-normal, light blue) and all text via the typography mixins'
--p-text-color (white) on a light page.

Pin both tokens to their light-theme values on the legacy content containers
(#content, breadcrumb nav, footer). Elements keep using the shared tokens, so
links, headings, footer and table text are all covered. The Vue menu mounts
inside #content and legitimately tracks the theme (inline Popovers use
--p-text-color), so it is re-asserted to the dark values under .open-dark and
renders unchanged.


  Commit: 878a55a33448c49ba396acc74d9b6c1d6129dff9
      https://github.com/OpenNMS/opennms/commit/878a55a33448c49ba396acc74d9b6c1d6129dff9
  Author: Scott Theleman <[email protected]>
  Date:   2026-07-21 (Tue, 21 Jul 2026)

  Changed paths:
    M ui/src/styles/opennms-styles.scss

  Log Message:
  -----------
  NMS-19981: Force native <select> to light rendering on legacy pages

In dark mode PrimeVue sets color-scheme: dark on the document, so the browser
painted native <select> controls (e.g. the Alarm/Event/Outage list filters,
select.form-control.custom-select) with a dark background — while their text is
pinned to the light-theme --p-text-color, leaving dark-on-dark and unreadable.
Legacy JSP pages are light-only, so set color-scheme: light on <select> to
render native controls (and their option popups) light in both modes. The Vue
menu uses PrimeVue components rather than native <select>, so it is unaffected.


Compare: https://github.com/OpenNMS/opennms/compare/794511b29e7e...878a55a33448

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs