[OpenNMS/opennms] 8f35e8: NMS-20006: bound local RPC execution to a fixed, c...

OpenNMS Machine User via opennms-cvs <[email protected]> Wed, 22 Jul 2026 13:55:37 -0700
Newsgroups	gmane.network.opennms.cvs
Message-ID	<OpenNMS/opennms/push/refs/heads/merge-foundation/foundation-2025-to-release-36.x/[email protected]>
  Branch: refs/heads/merge-foundation/foundation-2025-to-release-36.x
  Home:   https://github.com/OpenNMS/opennms
  Commit: 8f35e86a6fa16f1a45ba33d151bace5414aebdf5
      https://github.com/OpenNMS/opennms/commit/8f35e86a6fa16f1a45ba33d151bace5414aebdf5
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-21 (Tue, 21 Jul 2026)

  Changed paths:
    M core/ipc/rpc/api/src/main/java/org/opennms/core/rpc/api/RpcExceptionUtils.java
    M core/ipc/rpc/camel/src/main/java/org/opennms/core/rpc/camel/CamelRpcClientFactory.java
    A core/ipc/rpc/camel/src/test/java/org/opennms/core/rpc/camel/LocalRpcTimeoutTest.java
    M docs/modules/reference/pages/configuration/ttl-rpc.adoc

  Log Message:
  -----------
  NMS-20006: bound local RPC execution to a fixed, configurable timeout

Local (same-location) RPC execution in CamelRpcClientFactory is bounded
again so a module future that never completes cannot wedge its caller
(the NMS-19951 goal), but the bound is no longer the request TTL: it is
a fixed timeout, 30 minutes by default, configurable via the
org.opennms.core.ipc.rpc.local.timeout system property (0 disables).
TTL values resolved from snmp-config, service parameters, or the
collection interval no longer affect local execution, so
slow-but-completing local operations cannot be failed by configuration
intended for the Minion path.

RpcExceptionUtils now maps java.util.concurrent.TimeoutException to
onTimedOut, so an expired local execution is reported as a timeout
(e.g. CollectionTimedOut) rather than as an unexpected exception.


  Commit: 5e25bc2b22dbf3425f931a9f631df7cbde0180fe
      https://github.com/OpenNMS/opennms/commit/5e25bc2b22dbf3425f931a9f631df7cbde0180fe
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-21 (Tue, 21 Jul 2026)

  Changed paths:
    M smoke-test/src/main/java/org/opennms/smoketest/selenium/AbstractOpenNMSSeleniumHelper.java

  Log Message:
  -----------
  NMS-20049: harden smoke test login against CSRF/session race

Deleting cookies while the previous test's page is still loaded lets a
background request (e.g. a Vaadin heartbeat) race the login.jsp load
and swap the session cookie after the form is rendered. The form's
CSRF token then no longer matches, j_spring_security_check rejects the
POST and forwards to accessDenied.jsp, which passes login()'s
post-login checks. skipPasswordGate() then blocks for the full
timeout and the test runs unauthenticated, showing up as unrelated
flaky failures (GraphMLTopologyIT, TopologyIT, NodeDetailPageIT).

login() now parks on about:blank after cookie deletion so nothing can
race the form render, retries up to three times if the POST lands on
accessDenied.jsp, and skipPasswordGate() returns immediately when not
on the gate page instead of waiting for a button that never appears.


  Commit: 572db79e320b4841376b5eb58dc9b921a68aaac2
      https://github.com/OpenNMS/opennms/commit/572db79e320b4841376b5eb58dc9b921a68aaac2
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-22 (Wed, 22 Jul 2026)

  Changed paths:
    M core/ipc/rpc/api/src/main/java/org/opennms/core/rpc/api/RpcExceptionUtils.java
    M core/ipc/rpc/camel/src/main/java/org/opennms/core/rpc/camel/CamelRpcClientFactory.java
    A core/ipc/rpc/camel/src/test/java/org/opennms/core/rpc/camel/LocalRpcTimeoutTest.java
    M docs/modules/reference/pages/configuration/ttl-rpc.adoc

  Log Message:
  -----------
  Merge pull request #8641 from OpenNMS/mm/NMS-20006-smoke

NMS-20006: bound local RPC execution with a timeout decoupled from the TTL


  Commit: b6f6dde420a94c47288cef7596a7fd5f8fe9672e
      https://github.com/OpenNMS/opennms/commit/b6f6dde420a94c47288cef7596a7fd5f8fe9672e
  Author: Marshall Massengill <[email protected]>
  Date:   2026-07-22 (Wed, 22 Jul 2026)

  Changed paths:
    M smoke-test/src/main/java/org/opennms/smoketest/selenium/AbstractOpenNMSSeleniumHelper.java

  Log Message:
  -----------
  Merge pull request #8649 from OpenNMS/mm/NMS-20049-smoke

NMS-20049: harden smoke test login against CSRF/session race


  Commit: bde5a682dc6dc80c330d7ffda72af2f7eac82452
      https://github.com/OpenNMS/opennms/commit/bde5a682dc6dc80c330d7ffda72af2f7eac82452
  Author: CI/CD System <[email protected]>
  Date:   2026-07-22 (Wed, 22 Jul 2026)

  Changed paths:
    M core/ipc/rpc/api/src/main/java/org/opennms/core/rpc/api/RpcExceptionUtils.java
    M core/ipc/rpc/camel/src/main/java/org/opennms/core/rpc/camel/CamelRpcClientFactory.java
    A core/ipc/rpc/camel/src/test/java/org/opennms/core/rpc/camel/LocalRpcTimeoutTest.java
    M docs/modules/reference/pages/configuration/ttl-rpc.adoc
    M smoke-test/src/main/java/org/opennms/smoketest/selenium/AbstractOpenNMSSeleniumHelper.java

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/foundation-2024' into foundation-2025


  Commit: a5fa123ca6de4eae06b78ba4eaad808ce5768d9e
      https://github.com/OpenNMS/opennms/commit/a5fa123ca6de4eae06b78ba4eaad808ce5768d9e
  Author: Scott Theleman <[email protected]>
  Date:   2026-07-22 (Wed, 22 Jul 2026)

  Changed paths:
    M features/config/test/src/test/java/org/opennms/features/config/service/config/FakeXsdForTest.java
    M features/config/upgrade/pom.xml
    A features/config/upgrade/src/main/java/org/opennms/config/upgrade/TrapdSnmpv3UserIdBackfill.java
    M features/config/upgrade/src/main/java/org/opennms/config/upgrade/UpgradeConfigService.java
    M features/config/upgrade/src/main/resources/changelog-cm/36.0.0/changelog-cm.xml
    A features/config/upgrade/src/test/java/liquibase/ext2/cm/change/TrapdSchemaHashTest.java
    A features/config/upgrade/src/test/java/org/opennms/config/upgrade/TrapdSnmpv3UserIdBackfillIT.java
    M features/scv/api/src/main/java/org/opennms/features/scv/utils/ScvUtils.java
    M opennms-config-jaxb/src/main/java/org/opennms/netmgt/config/trapd/Snmpv3User.java
    M opennms-config-jaxb/src/main/java/org/opennms/netmgt/config/trapd/TrapdConfiguration.java
    A opennms-config-jaxb/src/main/resources/xsds/trapd-configuration-1.1.xsd
    M opennms-config-jaxb/src/test/java/org/opennms/netmgt/config/trapd/TrapdConfigurationTest.java
    M opennms-dao/src/main/java/org/opennms/netmgt/dao/jaxb/DefaultTrapdConfigDao.java
    M opennms-webapp-rest/pom.xml
    A opennms-webapp-rest/src/main/java/org/opennms/web/rest/support/MaskedCredential.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/support/SecurityHelper.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/TrapdRestService.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/api/TrapdRestApi.java
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/model/Snmpv3UserDto.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/support/SecurityHelperTest.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/TrapdRestServiceIT.java
    M ui/src/components/TrapdConfiguration/CreateSnmpV3User.vue
    M ui/src/components/TrapdConfiguration/SnmpV3UserManagement.vue
    M ui/src/components/TrapdConfiguration/TrapdAdvancedConfiguration.vue
    M ui/src/lib/scvValidator.ts
    A ui/src/lib/securityHelper.ts
    M ui/src/lib/snmpValidator.ts
    M ui/src/lib/trapdValidator.ts
    M ui/src/mappers/trapdConfig.mapper.ts
    M ui/src/types/trapConfig.d.ts
    M ui/tests/components/TrapdConfiguration/CreateSnmpV3User.test.ts
    M ui/tests/components/TrapdConfiguration/TrapdAdvancedConfiguration.test.ts
    A ui/tests/lib/trapdValidatorForm.test.ts
    A ui/tests/mappers/trapdConfig.mapper.test.ts

  Log Message:
  -----------
  NMS-19723: Mask credentials for Trapd config Rest API and UI (#8511)

* NMS-19723: Mask credentials for Trapd config Rest API

* NMS-19723: Backfill trapd SNMPv3 user ids at startup via UpgradeConfigService

* NMS-19723: Consolidate trapd CM config-name constant into TrapdConfiguration

* NMS-19723: Move SCV expression pattern into ScvUtils

* NMS-19723: Reject duplicate SNMPv3 user ids in Trapd config requests

* NMS-19723: Fix stale trapd v1.1 XSD hash in changelog and tripwire test

* NMS-19723: adminRole is a computed value, need to call '.value'

* Help updates for Snmpv3User

* NMS-19723: Fix tests after adminRole change. !smoke


  Commit: 0f4367597bdfaffaf20d967c4ccc8b5b8ebfe225
      https://github.com/OpenNMS/opennms/commit/0f4367597bdfaffaf20d967c4ccc8b5b8ebfe225
  Author: CI/CD System <[email protected]>
  Date:   2026-07-22 (Wed, 22 Jul 2026)

  Changed paths:
    M core/ipc/rpc/api/src/main/java/org/opennms/core/rpc/api/RpcExceptionUtils.java
    M core/ipc/rpc/camel/src/main/java/org/opennms/core/rpc/camel/CamelRpcClientFactory.java
    A core/ipc/rpc/camel/src/test/java/org/opennms/core/rpc/camel/LocalRpcTimeoutTest.java
    M docs/modules/reference/pages/configuration/ttl-rpc.adoc
    M smoke-test/src/main/java/org/opennms/smoketest/selenium/AbstractOpenNMSSeleniumHelper.java

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/foundation-2025' into release-36.x


Compare: https://github.com/OpenNMS/opennms/compare/01723b76d91c...0f4367597bdf

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs