[OpenNMS/opennms] 2577d9: NMS-20033: UI styling, behavior and pr review issu...

Scott Theleman via opennms-cvs <[email protected]> Mon, 27 Jul 2026 09:39:42 -0700
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/release-36.x/[email protected]>
  Branch: refs/heads/release-36.x
  Home:   https://github.com/OpenNMS/opennms
  Commit: 2577d90b75f443f19987b8c8d40c60cdb9c815d5
      https://github.com/OpenNMS/opennms/commit/2577d90b75f443f19987b8c8d40c60cdb9c815d5
  Author: Scott Theleman <[email protected]>
  Date:   2026-07-27 (Mon, 27 Jul 2026)

  Changed paths:
    M opennms-webapp/src/main/webapp/WEB-INF/jsp/admin/userGroupView/groups/list.jsp
    M opennms-webapp/src/main/webapp/admin/userGroupView/users/list.jsp
    M ui/src/components/Common/FormField.vue
    A ui/src/components/Common/OnmsIconButton.vue
    M ui/src/components/Configuration/ConfigurationAdvancedPanel.vue
    M ui/src/components/Configuration/ConfigurationCopyPasteDisplay.vue
    M ui/src/components/Configuration/ConfigurationCronSelector.vue
    M ui/src/components/Configuration/ConfigurationDrawer.vue
    M ui/src/components/Configuration/ConfigurationHelpPanel.vue
    M ui/src/components/Configuration/ConfigurationTable.vue
    M ui/src/components/Configuration/ConfigurationThreadPools.vue
    M ui/src/components/Configuration/ProvisionDForm.vue
    M ui/src/components/Device/DCBModalConfigDiffContent.vue
    M ui/src/components/Device/DCBModalViewHistoryContent.vue
    M ui/src/components/Device/DCBSearch.vue
    M ui/src/components/Device/DCBTable.vue
    M ui/src/components/EventConfigEventCreate/BasicInformation.vue
    M ui/src/components/EventConfiguration/Dialog/CreateEventConfigurationDialog.vue
    M ui/src/components/EventConfiguration/Dialog/UploadedFileRenameDialog.vue
    M ui/src/components/EventConfiguration/EventConfigSourceTable.vue
    M ui/src/components/EventConfiguration/EventConfigUploadFilesTab.vue
    M ui/src/components/EventConfigurationDetail/EventConfigEventTable.vue
    M ui/src/components/FileEditor/FileSidebar.vue
    M ui/src/components/FileEditor/Search.vue
    M ui/src/components/Layout/Footer.vue
    M ui/src/components/Logs/Editor.vue
    M ui/src/components/Map/LeafletMap.vue
    M ui/src/components/Map/SeverityFilter.vue
    M ui/src/components/Nodes/AssetFilterPanel.vue
    M ui/src/components/Nodes/ColumnSelectionDrawer.vue
    M ui/src/components/Nodes/ExtendedSearchPanel.vue
    M ui/src/components/Nodes/NodeActionsDropdown.vue
    M ui/src/components/Nodes/NodeAdvancedFiltersDrawer.vue
    M ui/src/components/Nodes/NodeDownloadDropdown.vue
    M ui/src/components/Nodes/NodesTable.vue
    M ui/src/components/Resources/Graph.vue
    M ui/src/components/Resources/Graphs.vue
    M ui/src/components/Resources/NodeResourceList.vue
    M ui/src/components/SCV/SCVAttribute.vue
    M ui/src/components/SCV/ScvInputIcon.vue
    M ui/src/components/SCV/ScvSearchDrawer.vue
    M ui/src/components/SnmpConfiguration/SnmpConfigDefinitionsTable.vue
    M ui/src/components/SnmpConfiguration/SnmpConfigProfilesTable.vue
    M ui/src/components/SnmpDataCollection/Dialog/UploadedFileRenameDialog.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionProfile/ProfileRrdSettingsTab.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionProfile/ProfileSourcesTab.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionProfile/SnmpDataCollectionProfileDetails.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionProfilesTable.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionSourceDetail/Drawer/MibGroupCreationDrawer.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionSourceDetail/Drawer/ResourceTypeCreationDrawer.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionSourceDetail/Drawer/SnmpDataCollectionSourceProfilesDrawer.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionSourceDetail/MibGroupsTable.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionSourceDetail/ResourceTypesTable.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionSourceDetail/SystemDefinitionsTable.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionSourceImport.vue
    M ui/src/components/SnmpDataCollection/SnmpDataCollectionSourcesTable.vue
    M ui/src/components/TrapdConfiguration/CreateSnmpV3User.vue
    M ui/src/components/TrapdConfiguration/SnmpV3UserManagement.vue
    M ui/src/components/ZenithConnect/ZenithConnectRegisterResult.vue
    M ui/src/components/ZenithConnect/ZenithConnectView.vue
    M ui/src/containers/DeviceConfigBackup.vue
    M ui/src/containers/SnmpDataCollection.vue
    M ui/src/styles/primevue-overrides.scss
    A ui/tests/components/Common/OnmsIconButton.test.ts

  Log Message:
  -----------
  NMS-20033: UI styling, behavior and pr review issues (post-PrimeVue migration) (#8657)

* NMS-20033: Add OnmsIconButton seam component

* Remove stale feather references

* Restore spacing lost with orphaned FeatherDS utility classes (NMS-20033)

* Resolve Leaflet map popup, overlay, layers, Esc, keep-alive, and resize issues (NMS-20033)

- Popups: extend the popupopen overflow pan to all axes (left/right/top +
  bottom), keeping autoPan off, so edge-marker popups no longer clip.
- Search/severity overlays: give .geo-map position: relative so they anchor to
  the map area instead of the viewport (were sliding under the pinned rail).
- Layers control: bridge the 5px hover gap with a transparent ::before so it no
  longer collapses mid-traverse; make the list theme-aware (--p-content-
  background/--p-text-color) instead of hardcoded #fff/#333.
- Esc cross-talk: ignore Esc originating in the map search (PrimeVue
  AutoComplete doesn't stopPropagation) so dismissing suggestions doesn't also
  close the marker popup.
- keep-alive: remove the document Esc listener in onDeactivated (Map is
  <keep-alive>'d and never unmounts, so onBeforeUnmount didn't fire).
- Resize: ResizeObserver -> debounced invalidateSize so the map reflows when
  the side menu is pinned (padding-left on .app-layout) or on any resize.

- Reduce map control top inset from 80px to 2em (NMS-20033)

* Align and size-normalize DCB action-button icons (NMS-20033)

* Outline all text-variant Cancel buttons (NMS-20033)

* dcb fix

* Show border on outlined+text buttons (NMS-20033)

* Normalize search-input icon size to 1.5rem (NMS-20033)

* Destroy Chart.js instances to stop canvas reuse errors on resource graphs (NMS-20033)

* Await graph definitions before navigating on Graph All (NMS-20033)

* Seed resource graphs reactively from the store (NMS-20033)

* Uppercase resource-graph tabs; fix oversized profiles autocomplete (NMS-20033)

- Graph.vue: uppercase the Graph/Data tab labels (text-transform on .p-tab).
- SnmpDataCollectionSourceProfilesDrawer: the Add Profile AutoComplete isn't in
  a FormField, so its input inherited the global 3.75rem .p-inputtext height and
  read too tall. Constrain it to the app-standard 3rem (the value FormField
  applies), matching the correctly-sized System Definition MIB Groups control.

* Promote 3rem input height to global; wrap two form autocompletes in FormField (NMS-20033)

- Wrap the 'Add Profile' (SnmpDataCollectionSourceProfilesDrawer) and 'Add
  Source' (ProfileSourcesTab) autocompletes in FormField for label/structure
  consistency; remove the bespoke height CSS added earlier (global now covers it).

* Give the footer a dark background in dark mode (NMS-20033)

* Migrate SNMP config table icon buttons to OnmsIconButton (NMS-20033)

* Reattach map popup Esc listener on keep-alive reactivation (NMS-20033)

* Share one debounced graph search across keystrokes (NMS-20033) !smoke



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs