Re: [PATCH] remove misleading space between operator and value in options

thanks, applied

On Sat, 18 Jul 2026, serity--- via openssh-unix-dev wrote:

> There are only a few cases in the openssh codebase where options use the syntax
> "option = - 1" instead of the "option = -1" that is used for every other
> option.
> 
> This was a problem because I could not find those few options when I was
> grepping for literal "-1".
> 
> If this patch is accepted, I don't want any recognition nor authorship. It's
> trivial.
> 
> diff --git a/readconf.c b/readconf.c
> index ae00a58..9ab5066 100644
> --- a/readconf.c
> +++ b/readconf.c
> @@ -2756,10 +2756,10 @@ initialize_options(Options * options)
>         options->bind_interface = NULL;
>         options->pkcs11_provider = NULL;
>         options->sk_provider = NULL;
> -       options->enable_ssh_keysign = - 1;
> -       options->no_host_authentication_for_localhost = - 1;
> -       options->identities_only = - 1;
> -       options->rekey_limit = - 1;
> +       options->enable_ssh_keysign = -1;
> +       options->no_host_authentication_for_localhost = -1;
> +       options->identities_only = -1;
> +       options->rekey_limit = -1;
>         options->rekey_interval = -1;
>         options->verify_host_key_dns = -1;
>         options->server_alive_interval = -1;
> @@ -2940,7 +2940,7 @@ fill_default_options(Options * options)
>                 options->log_level = SYSLOG_LEVEL_INFO;
>         if (options->log_facility == SYSLOG_FACILITY_NOT_SET)
>                 options->log_facility = SYSLOG_FACILITY_USER;
> -       if (options->no_host_authentication_for_localhost == - 1)
> +       if (options->no_host_authentication_for_localhost == -1)
>                 options->no_host_authentication_for_localhost = 0;
>         if (options->identities_only == -1)
>                 options->identities_only = 0;
> _______________________________________________
> openssh-unix-dev mailing list
> [email protected]
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
>