[XS] Change in openvpn[master]: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
"flichtenheld (Code Review)" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <[email protected]> |
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email
to review the following change.
Change subject: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
......................................................................
openvpnmsica: Fix setting of iTicks in schedule_adapter_delete
Increase the integer, not the pointer.
Found by cppcheck.
Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpnmsica/openvpnmsica.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/08/1608/1
diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsica.c
index a145b64..fdb610c 100644
--- a/src/openvpnmsica/openvpnmsica.c
+++ b/src/openvpnmsica/openvpnmsica.c
@@ -613,7 +613,7 @@
msica_arg_seq_add_tail(seq, szArgument);
}
- iTicks += MSICA_ADAPTER_TICK_SIZE;
+ *iTicks += MSICA_ADAPTER_TICK_SIZE;
break; /* Adapter names are unique. There should be no other adapter with this name. */
}
}
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1608?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
Gerrit-Change-Number: 1608
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel