[PATCH applied] Re: win: Fix nrpt_dnssec flag handling
Gert Doering <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <[email protected]> |
Good catch, and obvious bug... and use of enum for a "bit map style"
flags thing was not really a good approach in the first place. Now it
will work ("any value *but* 0 will work"), but when this is extended
to cover "more than 1 flag", going away from the enum would be a good
plan. For the bug fix, a minimal approach is suitable.
I have not tested this beyond "does it compile on Ubuntu/MinGW", but
it looks very obviously correct ("stare at 'git grep nrpt_dnssec'").
Your patch has been applied to the master and release/2.7 branch.
commit 08a19843a184c6cb8850ac9e6bf7ce0cd4d15d37 (master)
commit 2aaa5e4d7c5bae35d7befdebeed065c634292151 (release/2.7)
Author: Frank Lichtenheld
Date: Sun Apr 5 12:22:04 2026 +0200
win: Fix nrpt_dnssec flag handling
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1606
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg36487.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering