[PATCH applied] Re: push: Make prepare_push_reply return void
Gert Doering <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <[email protected]> |
Interesting find. I guess someone in some distant past assumed that
we might see failure modes for prepare_push_reply()...
stare-at-code says "this must be fine", but as it affects server code,
I subjected it to the t_server testbed which does excercise PUSH quite
a bit :-) - and everything still works.
Your patch has been applied to the master branch.
commit 5d7068fa181edd472cb55889bd8fdfe246ecede4
Author: Frank Lichtenheld
Date: Mon Apr 6 09:26:11 2026 +0200
push: Make prepare_push_reply return void
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1616
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg36514.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering