Re: [PATCH applied] Re: Log when writing username/password to TLS buffer fails
Selva Nair <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <CAKuzo_hEqNHtmhqtUJPXpcuqjAc6vYQXsMB7k0BgrkA_xBu2Sw@mail.gmail.com> |
> I have not tested it - I guess one needs a GUI with "long password" support to trigger it :-) Not really.. long passwords work via the console even in pre-2.6 ! A password longer than about 1700 bytes will trigger it. Selva On Tue, Apr 14, 2026 at 12:31 PM Gert Doering <[email protected]> wrote: > > Thanks, this makes sense - if we fail, we want to tell the user what > happened (even if we then continue to run in silly circles). > > I have not tested it - I guess one needs a GUI with "long password" > support to trigger it :-) - but since the code path is clear enough > and the patch only adds msg() calls, I guess a compile test is fine. > > Your patch has been applied to the master and release/2.7 branch > (I put this into "documentation improvement"). > > commit fd1fd077ea7781be8be6e05f2a2b657619c7e437 (master) > commit 784ba7a2019539db028cd98beaa42e8921394cdf (release/2.7) > Author: Selva Nair > Date: Tue Apr 14 07:57:14 2026 +0200 > > Log when writing username/password to TLS buffer fails > > Signed-off-by: Selva Nair <[email protected]> > Acked-by: Arne Schwabe <[email protected]> > Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1600 > Message-Id: <[email protected]> > URL: https://www.mail-archive.com/[email protected]/msg36604.html > Signed-off-by: Gert Doering <[email protected]> > > > -- > kind regards, > > Gert Doering > _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel