[XS] Change in openvpn[master]: ssl_mbedtls: Fix format string in get_ssl_library_version
"cron2 (Code Review)" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <[email protected]> |
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1626?usp=email ) Change subject: ssl_mbedtls: Fix format string in get_ssl_library_version ...................................................................... ssl_mbedtls: Fix format string in get_ssl_library_version These are unsigned values, so treat them as such. Identified by cppcheck. Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Arne Schwabe <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1626 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg36607.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/ssl_mbedtls.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index a62ff76..85c771a 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -1572,7 +1572,7 @@ { static char mbedtls_version[30]; unsigned int pv = mbedtls_version_get_number(); - snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d", (pv >> 24) & 0xff, + snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %u.%u.%u", (pv >> 24) & 0xff, (pv >> 16) & 0xff, (pv >> 8) & 0xff); return mbedtls_version; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1626?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Gerrit-Change-Number: 1626 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel