[S] Change in openvpn[master]: Enable per-socket bind_dev via --local
"flichtenheld (Code Review)" <[email protected]>
| Newsgroups | gmane.network.openvpn.devel |
|---|---|
| Message-ID | <8653032900102522943fde2795546c285bd8b462-EmailReviewComments-HTML@gerrit.openvpn.net> |
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1625?usp=email ) Change subject: Enable per-socket bind_dev via --local ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File doc/man-sections/link-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1625/comment/ae0af796_9da7928a?usp=email : PS3, Line 121: The optional arguments correspond to existing options: ``port`` to Maybe better: The optional arguments override defaults set by the following options: * ``port`` overrides ``--lport`` * ``protocol`` overrides ``--proto`` * ``bind device`` overrides ``--bind-dev`` (To explicitly say that these options set defaults which we can then override) File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1625/comment/182e6971_7f4b5f87?usp=email : PS3, Line 11: This option can also be used inside a ``--local`` statement Maybe better: The default defined by this option can be overridden on a per-socket basis by specifying a ``bind device`` argument to ``--local``. The current text sounds like you can use ``--bind-dev`` in a different context which is not correct. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1625?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6319c951327a9b994ffae0ba35270b0887455203 Gerrit-Change-Number: 1625 Gerrit-PatchSet: 3 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Comment-Date: Wed, 15 Apr 2026 15:41:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel