[XS] Change in openvpn[master]: Avoid recursive call of man_read

selvanair has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1639?usp=email )

Change subject: Avoid recursive call of man_read
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
Although FD_READ is level triggered,MSDN has this:
".. an application need not read all available data in response to an FD_READ network event—a single recv in response to each FD_READ network event is appropriate."

This is problematic, as it requires at least one recv() to get the event to re-trigger. So, man_read() retruning without recv() as proposed here may not be fool-proof? Unfortunately recv with zero bytes is a no-op, so that's not an option either.

Back to square one?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1639?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9433baee1f5a66d43d4e43e03128ae6a790a7937
Gerrit-Change-Number: 1639
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Comment-Date: Mon, 27 Apr 2026 20:14:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel