[S] Change in openvpn[master]: dns: correctly handle dnssec settings

Attention is currently required from: plaisthos, selvanair.

d12fk has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email )

Change subject: dns: correctly handle dnssec settings
......................................................................


Patch Set 1:

(3 comments)

File include/openvpn-msg.h:

http://gerrit.openvpn.net/c/openvpn/+/1643/comment/50d1fe53_70ec2803?usp=email :
PS1, Line 114:     nrpt_dnssec_required = 1 << 1,
Is this really needed? As far as I can remember Windows has no `optional` setting, i.e. always validates.


File src/openvpn/dns.h:

http://gerrit.openvpn.net/c/openvpn/+/1643/comment/a25c8f87_72ceb6a7?usp=email :
PS1, Line 32:     DNS_SECURITY_UNSET,
Not sure if we should get rid of `unset` since might not have a `optional` setting. In that case we need to fall back to something different when the value is unset, like `no`.


File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/1643/comment/15034e37_b0b146a1?usp=email :
PS1, Line 2472:             nrpt_flags_t dnssec)
Think it makes sense to rename `dnssec` -> `flags` or `nrpt_flags`, since it could have additional things in the future potentially



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id514b06223cb55295c92b1fa6727f03d6e06befe
Gerrit-Change-Number: 1643
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: d12fk <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: selvanair <[email protected]>
Gerrit-Comment-Date: Wed, 29 Apr 2026 12:42:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel