[S] Change in openvpn[master]: dns: correctly handle dnssec settings

Attention is currently required from: d12fk, flichtenheld, plaisthos.

selvanair has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email )

Change subject: dns: correctly handle dnssec settings
......................................................................


Patch Set 1:

(2 comments)

File include/openvpn-msg.h:

http://gerrit.openvpn.net/c/openvpn/+/1643/comment/9cac179c_8ab54db3?usp=email :
PS1, Line 114:     nrpt_dnssec_required = 1 << 1,
> man-page  says user can set  optional, and I had no idea how to provide that rather than this. […]
Shall we treat "optional" as "no" on Windows and document that?


http://gerrit.openvpn.net/c/openvpn/+/1643/comment/e2022f21_8cd8e2bf?usp=email :
PS1, Line 127:     nrpt_flags_t flags;
> I was questioning whether it is clean to set a variable of an enum type to a value that is not a nam […]
Aha, now I get it :)
Agreed, better to make flags an int. That would need to define DNS_SECURITY_NO, _OPTIONAL, _YES as 0, 1<<0, 1<<1, and move those to openvpn-msg.h as well?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id514b06223cb55295c92b1fa6727f03d6e06befe
Gerrit-Change-Number: 1643
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: d12fk <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Comment-Date: Wed, 29 Apr 2026 15:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: d12fk <[email protected]>
Comment-In-Reply-To: selvanair <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel