[S] Change in openvpn[master]: dns: correctly handle dnssec settings

Attention is currently required from: d12fk, plaisthos, selvanair.

flichtenheld has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email )

Change subject: dns: correctly handle dnssec settings
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/dns.h:

http://gerrit.openvpn.net/c/openvpn/+/1643/comment/cfa08e49_08aa2a52?usp=email :
PS1, Line 32:     DNS_SECURITY_UNSET,
> As "dns server n dnssec foo" is not a mandatory option, UNSET is useless and error-prone. […]
"UNSET is not handled anywhere." I looked into that and this is not true. We never use `DNS_SECURITY_UNSET` explicitly in the code. But a lot of the DNS options code does things like `if (s->dnssec)` so we have actually a lot of implicit checks for it. E.g. when running the dns script we put nothing in the environment when it is UNSET, and only put "yes", "no", "optional" if explicitly set.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id514b06223cb55295c92b1fa6727f03d6e06befe
Gerrit-Change-Number: 1643
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: d12fk <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Attention: selvanair <[email protected]>
Gerrit-Comment-Date: Thu, 30 Apr 2026 12:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: d12fk <[email protected]>
Comment-In-Reply-To: selvanair <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel