[S] Change in openvpn[master]: dns: correctly handle dnssec settings

Attention is currently required from: d12fk, plaisthos, selvanair.

flichtenheld has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email )

Change subject: dns: correctly handle dnssec settings
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/dns.h:

http://gerrit.openvpn.net/c/openvpn/+/1643/comment/41584b3e_2dda66f8?usp=email :
PS1, Line 32:     DNS_SECURITY_UNSET,
> Well, in that case, UNSET stays, and with the immediate fix in, nothing in this patch may be abandon […]
I would say so. If someone actually asks for DNS_SECURITY_OPTIONAL support on Windows, we could certainly look into it, but it feels like not worth the additional complexity to me at this point.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1643?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id514b06223cb55295c92b1fa6727f03d6e06befe
Gerrit-Change-Number: 1643
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: d12fk <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Attention: selvanair <[email protected]>
Gerrit-Comment-Date: Thu, 30 Apr 2026 13:23:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: d12fk <[email protected]>
Comment-In-Reply-To: selvanair <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel