Re: Fwd: [PATCH] netcfg: handle ParseFromString result for protobuf 34 (nodiscard)

On 04/05/2026 09:22, Дмитрий Романов via Openvpn-devel wrote:
[...]
>  
> Building openvpn3-linux v26 with protobuf 34.x and GCC 15 fails in
> netcfg-dco.cpp: google::protobuf::MessageLite::ParseFromString is now
> [[nodiscard]], and the project builds with -Werror, so ignoring the
> return value becomes a hard error (-Werror=unused-result).
>  
> Check the return value and throw NetCfgException on parse failure,
> consistent with other error handling in this file.
>  
> This should fix distributions that already ship protobuf 34 (e.g. Arch).
>  
> If there is an existing issue on Codeberg for this (e.g. related to
> nodiscard / protobuf 34), please link this patch there.
>  
> Signed-off-by: Dmitriy Romanov <[email protected]
> <mailto:[email protected]>>
>  

Hi,

Thanks a lot for this patch.  This issue was reported quite recently
while digging into some other issues.  It is being tracked in Codeberg
issue #96: <https://codeberg.org/OpenVPN/openvpn3-linux/issues/96>

I'm following up on that ticket closely and will provide more updates in
the days to come.


-- 
kind regards,

David Sommerseth



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel