[PATCH applied] Re: tun: Remove one useless if check

Gert Doering <[email protected]>
Newsgroups gmane.network.openvpn.devel
Message-ID <[email protected]>
And indeed, cppcheck is right again... - best seen with "git show -w -U12"
(... I guess the outer clause was something like "DCO or wintun" at some
point in time...).

It's technically not even a bug just an ugly bit of code, so not backporting 
to release/2.7

Not tested.  Just stared at code, and at "buildbot all green"... *ahem*...
on Ubuntu, that is - the build fail on FreeBSD 14 is caused by 1675 v2,
and this one has not been pushed again.  t_client tested on FreeBSD :-)

Your patch has been applied to the master branch.

commit 1400926adada824973a3df001fdcc46f523d90ee
Author: Frank Lichtenheld
Date:   Fri May 8 17:34:53 2026 +0200

     tun: Remove one useless if check

     Signed-off-by: Frank Lichtenheld <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1677
     Message-Id: <[email protected]>
     URL: https://www.mail-archive.com/[email protected]/msg36867.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.