[M] Change in openvpn[master]: lladdr: Clean up code

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1675?usp=email )

Change subject: lladdr: Clean up code
......................................................................


Patch Set 3: Code-Review-2

(1 comment)

Patchset:

PS3: 
OpenBSD does not agree with the resulting #defines...  with the patch, I see

```
2026-05-12 16:59:43 tun/tap device [tap0] opened
2026-05-12 16:59:43 
ifconfig: ether: bad value
2026-05-12 16:59:43 ERROR: Unable to set link layer address.: external program exited with error status: 1
```

in my logs... the old code does

```
2026-05-12 17:00:54 TUN/TAP device /dev/tap0 opened
2026-05-12 17:00:54 /sbin/ifconfig tap0 lladdr fe:e1:ba:dd:5d:2e
2026-05-12 17:00:54 TUN/TAP link layer address set to fe:e1:ba:dd:5d:2e
```



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1675?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibe7b3c17176c97a1cbb4d9cc87735b05e62c4f43
Gerrit-Change-Number: 1675
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 12 May 2026 15:21:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel