[M] Change in openvpn[master]: Add support for user defined L3 master devices

Attention is currently required from: flichtenheld, plaisthos.

its_Giaan has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1703?usp=email )

Change subject: Add support for user defined L3 master devices
......................................................................


Patch Set 2:

(5 comments)

File doc/man-sections/vpn-network-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1703/comment/2140ddc6_b93cfce6?usp=email :
PS1, Line 307: --l3mdev name
> this needs an explanation on how it is different to --bind-dev which seems to claim to offer the sam […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1703/comment/5a39a19c_13dc55b7?usp=email :
PS1, Line 308:    Specify the L3 master device (such as VRF) to which the tunnel 
> trailing whitespace
Done


File src/openvpn/networking_sitnl.c:

http://gerrit.openvpn.net/c/openvpn/+/1703/comment/6f90f26b_12ca8a84?usp=email :
PS1, Line 1063:     int ifindex, l3mdev_index, ret = -1;
> there is no reason to initialize values to -1 if you do overwrite this immediately. […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1703/comment/754466b4_0c633fc3?usp=email :
PS1, Line 1067:     ifindex = if_nametoindex(iface);
> just initialize the variable here.
Done


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1703/comment/07015eeb_a463f171?usp=email :
PS1, Line 6499:     else if (streq(p[0], "l3mdev") && p[1] && !p[2])
> Addition to usage string seems to be missing
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1703?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I115a17a2c61c65f48aea41d94150f34ea31f82da
Gerrit-Change-Number: 1703
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 10 Jun 2026 11:35:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel