[M] Change in openvpn[master]: Multisocket: use event engine rwflags for UDP I/O

Attention is currently required from: cron2, ordex, plaisthos.

its_Giaan has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1635?usp=email )

Change subject: Multisocket: use event engine rwflags for UDP I/O
......................................................................


Patch Set 6:

(5 comments)

File src/openvpn/forward.h:

http://gerrit.openvpn.net/c/openvpn/+/1635/comment/b33923dd_b35dd207?usp=email :
PS5, Line 78: 
> can we have proper documentation comments here?
Done


File src/openvpn/forward.c:

http://gerrit.openvpn.net/c/openvpn/+/1635/comment/32383fc8_4265d587?usp=email :
PS5, Line 2035: {
> This function most definitely needs a comment to explain what it does, and where it is called from ( […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1635/comment/86200023_d64fa367?usp=email :
PS5, Line 2132:  */
> We need to extend this comment a bit - the fact that it deals with only one socket confuses me every […]
Done


File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/1635/comment/37b6bec0_fd604124?usp=email :
PS5, Line 364: p2mp_iow_flags(const struct multi_context *m, struct link_socket *sock)
> let's move this function to multi_io. […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1635/comment/83887180_78763e16?usp=email :
PS5, Line 375:         if (LINK_OUT(&m->pending->context) && m->pending->context.c2.link_sockets[0] == sock)
> I have my doubts about this change - IOW, I am not understanding this at all. […]
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1635?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6b303805a3688b6f6363140c76853a58badecd8f
Gerrit-Change-Number: 1635
Gerrit-PatchSet: 6
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Mon, 15 Jun 2026 10:06:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel