[S] Change in openvpn[master]: Extract multi_get_instance_real_udp_real method

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1725?usp=email )

Change subject: Extract multi_get_instance_real_udp_real method
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/1725/comment/ea313ee4_ec462b69?usp=email :
PS2, Line 264:  * @return      instance matching the NULL otherwise
missing word after "the"


http://gerrit.openvpn.net/c/openvpn/+/1725/comment/a0104c6b_d07b695e?usp=email :
PS2, Line 267: multi_get_instance_real_udp_real(struct multi_context *m, struct mroute_addr *real)
why the doubled "real" in the name?


http://gerrit.openvpn.net/c/openvpn/+/1725/comment/33ed15bb_ff5fbcae?usp=email :
PS2, Line 298:         const uint64_t hv = hash_value(hash, &real);
why is it better to call this up to three times instead of once?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1725?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37ade55d7674c68dd98cf4dfde35c4ad42e20d39
Gerrit-Change-Number: 1725
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jun 2026 15:58:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel