[S] Change in openvpn[master]: multi: don't let stale-routes-check delete permanent routes

Attention is currently required from: ordex.

plaisthos has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1729?usp=email )

Change subject: multi: don't let stale-routes-check delete permanent routes
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1729/comment/edd0f44c_5462d744?usp=email :
PS1, Line 1363:         if (multi_route_defined(m, r) && !(r->flags & MULTI_ROUTE_PERMANENT)
Why do we need the PERMANENT flag? Cannot we just use here r->flags & MULTI_ROUTE_CACHE? Or are there routes that are not cached that we want to remove here as well?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1729?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3f9834cc13c49b9249653d7d8637383f50c2fb87
Gerrit-Change-Number: 1729
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jun 2026 09:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel